third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from Kent; merge. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

index bd12bf13dc5d2de9f75df2e808a6c49e70e56166..d3d7b2bdabdd7db3ca0a1255d06b6aab76d65de1 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

@@ -28,6 +28,7 @@

#include "core/html/canvas/CanvasRenderingContextFactory.h"

#include "modules/webgl/WebGLRenderingContextBase.h"

+#include <memory>

namespace blink {

@@ -64,8 +65,8 @@ public:

DECLARE_VIRTUAL_TRACE_WRAPPERS();

private:

- WebGLRenderingContext(HTMLCanvasElement*, PassOwnPtr<WebGraphicsContext3DProvider>, const WebGLContextAttributes&);

- WebGLRenderingContext(OffscreenCanvas*, PassOwnPtr<WebGraphicsContext3DProvider>, const WebGLContextAttributes&);

+ WebGLRenderingContext(HTMLCanvasElement*, std::unique_ptr<WebGraphicsContext3DProvider>, const WebGLContextAttributes&);

+ WebGLRenderingContext(OffscreenCanvas*, std::unique_ptr<WebGraphicsContext3DProvider>, const WebGLContextAttributes&);

// Enabled extension objects.

Member<ANGLEInstancedArrays> m_angleInstancedArrays;