third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptState.h » ('j') | third_party/WebKit/Source/core/dom/ExecutionContextTask.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

index 10a1cf50cf88fd09637470aceee8f49a60239f11..e1f7e55d10196a025f46719ad2c418adc7e42e5e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp

@@ -11,6 +11,7 @@

#include "core/dom/Document.h"

#include "core/testing/DummyPageHolder.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include <memory>

#include <v8.h>

namespace blink {

@@ -62,7 +63,7 @@ public:

v8::MicrotasksScope::PerformCheckpoint(isolate());

}

- OwnPtr<DummyPageHolder> m_pageHolder;

+ std::unique_ptr<DummyPageHolder> m_pageHolder;

ScriptState* getScriptState() const { return ScriptState::forMainWorld(&m_pageHolder->frame()); }

ExecutionContext* getExecutionContext() const { return &m_pageHolder->document(); }

v8::Isolate* isolate() const { return getScriptState()->isolate(); }