third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h b/third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

index 83b87cd569cdc35a14c7f1232ac27a176553549d..c1d44eccf624e785c0a895bdb2d110df7ddbbd03 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

@@ -33,6 +33,7 @@

#include "wtf/Allocator.h"

#include "wtf/Noncopyable.h"

+#include <memory>

#include <v8.h>

namespace blink {

@@ -92,7 +93,7 @@ public:

m_handle.Reset(isolate, handle);

}

- // Note: This is clear in the OwnPtr sense, not the v8::Handle sense.

+ // Note: This is clear in the std::unique_ptr sense, not the v8::Handle sense.

void clear()

{

m_handle.Reset();