third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

index b39a29e39e8d1ba67ff9653ca1fa2f6a11c3299a..1cc2e7f4c574139d1c540f55839b8e2b394b30e8 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

@@ -18,10 +18,9 @@

#include "core/testing/GarbageCollectedScriptWrappable.h"

#include "platform/heap/Handle.h"

#include "testing/gtest/include/gtest/gtest.h"

-#include "wtf/OwnPtr.h"

-#include "wtf/PassOwnPtr.h"

#include "wtf/PassRefPtr.h"

#include "wtf/RefPtr.h"

+#include <memory>

#include <v8.h>

using namespace blink;

@@ -144,7 +143,7 @@ public:

}

private:

- OwnPtr<DummyPageHolder> m_page;

+ std::unique_ptr<DummyPageHolder> m_page;

RefPtr<ScriptState> m_otherScriptState;

};