third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

index 91d839fe67e4db8be531cf62cae607c5de9c154d..8040ac1ad47809a61e58329c7f8e9e44f92bf8af 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

@@ -41,6 +41,7 @@

#include "public/platform/modules/serviceworker/WebServiceWorkerSkipWaitingCallbacks.h"

#include "wtf/Forward.h"

#include "wtf/Noncopyable.h"

+#include <memory>

namespace blink {

@@ -79,8 +80,8 @@ public:

virtual void didHandleNotificationCloseEvent(int eventID, WebServiceWorkerEventResult) = 0;

virtual void didHandlePushEvent(int pushEventID, WebServiceWorkerEventResult) = 0;

virtual void didHandleSyncEvent(int syncEventID, WebServiceWorkerEventResult) = 0;

- virtual void postMessageToClient(const WebString& clientUUID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) = 0;

- virtual void postMessageToCrossOriginClient(const WebCrossOriginServiceWorkerClient&, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) = 0;

+ virtual void postMessageToClient(const WebString& clientUUID, const WebString& message, std::unique_ptr<WebMessagePortChannelArray>) = 0;

+ virtual void postMessageToCrossOriginClient(const WebCrossOriginServiceWorkerClient&, const WebString& message, std::unique_ptr<WebMessagePortChannelArray>) = 0;

virtual void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) = 0;

virtual void claim(WebServiceWorkerClientsClaimCallbacks*) = 0;

virtual void focus(const WebString& clientUUID, WebServiceWorkerClientCallbacks*) = 0;