Index: third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp |
diff --git a/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp b/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp |
index c7869ca20bace4f25d88021428989276b3fb00e5..defd82911b3fe6b64db20566556e4df06363a7d3 100644 |
--- a/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp |
+++ b/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp |
@@ -15,7 +15,8 @@ |
#include "platform/testing/UnitTestHelpers.h" |
#include "testing/gmock/include/gmock/gmock.h" |
#include "testing/gtest/include/gtest/gtest.h" |
-#include "wtf/OwnPtr.h" |
+#include "wtf/PtrUtil.h" |
+#include <memory> |
namespace blink { |
@@ -31,7 +32,7 @@ using MockFetchDataLoaderClient = DataConsumerHandleTestUtil::MockFetchDataLoade |
class FakeLoaderFactory : public FetchBlobDataConsumerHandle::LoaderFactory { |
public: |
- PassOwnPtr<ThreadableLoader> create(ExecutionContext&, ThreadableLoaderClient*, const ThreadableLoaderOptions&, const ResourceLoaderOptions&) override |
+ std::unique_ptr<ThreadableLoader> create(ExecutionContext&, ThreadableLoaderClient*, const ThreadableLoaderOptions&, const ResourceLoaderOptions&) override |
{ |
ASSERT_NOT_REACHED(); |
return nullptr; |
@@ -50,7 +51,7 @@ protected: |
ScriptState* getScriptState() { return ScriptState::forMainWorld(m_page->document().frame()); } |
ExecutionContext* getExecutionContext() { return &m_page->document(); } |
- OwnPtr<DummyPageHolder> m_page; |
+ std::unique_ptr<DummyPageHolder> m_page; |
ScriptValue eval(const char* s) |
{ |
@@ -93,7 +94,7 @@ TEST_F(BodyStreamBufferTest, Tee) |
EXPECT_CALL(*client2, didFetchDataLoadedString(String("hello, world"))); |
EXPECT_CALL(checkpoint, Call(4)); |
- OwnPtr<DataConsumerHandleTestUtil::ReplayingHandle> handle = DataConsumerHandleTestUtil::ReplayingHandle::create(); |
+ std::unique_ptr<DataConsumerHandleTestUtil::ReplayingHandle> handle = DataConsumerHandleTestUtil::ReplayingHandle::create(); |
handle->add(DataConsumerHandleTestUtil::Command(DataConsumerHandleTestUtil::Command::Data, "hello, ")); |
handle->add(DataConsumerHandleTestUtil::Command(DataConsumerHandleTestUtil::Command::Data, "world")); |
handle->add(DataConsumerHandleTestUtil::Command(DataConsumerHandleTestUtil::Command::Done)); |
@@ -173,7 +174,7 @@ TEST_F(BodyStreamBufferTest, TeeFromHandleMadeFromStream) |
TEST_F(BodyStreamBufferTest, DrainAsBlobDataHandle) |
{ |
- OwnPtr<BlobData> data = BlobData::create(); |
+ std::unique_ptr<BlobData> data = BlobData::create(); |
data->appendText("hello", false); |
auto size = data->length(); |
RefPtr<BlobDataHandle> blobDataHandle = BlobDataHandle::create(std::move(data), size); |
@@ -193,7 +194,7 @@ TEST_F(BodyStreamBufferTest, DrainAsBlobDataHandle) |
TEST_F(BodyStreamBufferTest, DrainAsBlobDataHandleReturnsNull) |
{ |
// This handle is not drainable. |
- OwnPtr<FetchDataConsumerHandle> handle = createFetchDataConsumerHandleFromWebHandle(createWaitingDataConsumerHandle()); |
+ std::unique_ptr<FetchDataConsumerHandle> handle = createFetchDataConsumerHandleFromWebHandle(createWaitingDataConsumerHandle()); |
BodyStreamBuffer* buffer = new BodyStreamBuffer(getScriptState(), std::move(handle)); |
EXPECT_FALSE(buffer->isStreamLocked()); |
@@ -249,7 +250,7 @@ TEST_F(BodyStreamBufferTest, DrainAsFormData) |
TEST_F(BodyStreamBufferTest, DrainAsFormDataReturnsNull) |
{ |
// This handle is not drainable. |
- OwnPtr<FetchDataConsumerHandle> handle = createFetchDataConsumerHandleFromWebHandle(createWaitingDataConsumerHandle()); |
+ std::unique_ptr<FetchDataConsumerHandle> handle = createFetchDataConsumerHandleFromWebHandle(createWaitingDataConsumerHandle()); |
BodyStreamBuffer* buffer = new BodyStreamBuffer(getScriptState(), std::move(handle)); |
EXPECT_FALSE(buffer->isStreamLocked()); |
@@ -293,7 +294,7 @@ TEST_F(BodyStreamBufferTest, LoadBodyStreamBufferAsArrayBuffer) |
EXPECT_CALL(*client, didFetchDataLoadedArrayBufferMock(_)).WillOnce(SaveArg<0>(&arrayBuffer)); |
EXPECT_CALL(checkpoint, Call(2)); |
- OwnPtr<ReplayingHandle> handle = ReplayingHandle::create(); |
+ std::unique_ptr<ReplayingHandle> handle = ReplayingHandle::create(); |
handle->add(Command(Command::Data, "hello")); |
handle->add(Command(Command::Done)); |
BodyStreamBuffer* buffer = new BodyStreamBuffer(getScriptState(), createFetchDataConsumerHandleFromWebHandle(std::move(handle))); |
@@ -325,7 +326,7 @@ TEST_F(BodyStreamBufferTest, LoadBodyStreamBufferAsBlob) |
EXPECT_CALL(*client, didFetchDataLoadedBlobHandleMock(_)).WillOnce(SaveArg<0>(&blobDataHandle)); |
EXPECT_CALL(checkpoint, Call(2)); |
- OwnPtr<ReplayingHandle> handle = ReplayingHandle::create(); |
+ std::unique_ptr<ReplayingHandle> handle = ReplayingHandle::create(); |
handle->add(Command(Command::Data, "hello")); |
handle->add(Command(Command::Done)); |
BodyStreamBuffer* buffer = new BodyStreamBuffer(getScriptState(), createFetchDataConsumerHandleFromWebHandle(std::move(handle))); |
@@ -355,7 +356,7 @@ TEST_F(BodyStreamBufferTest, LoadBodyStreamBufferAsString) |
EXPECT_CALL(*client, didFetchDataLoadedString(String("hello"))); |
EXPECT_CALL(checkpoint, Call(2)); |
- OwnPtr<ReplayingHandle> handle = ReplayingHandle::create(); |
+ std::unique_ptr<ReplayingHandle> handle = ReplayingHandle::create(); |
handle->add(Command(Command::Data, "hello")); |
handle->add(Command(Command::Done)); |
BodyStreamBuffer* buffer = new BodyStreamBuffer(getScriptState(), createFetchDataConsumerHandleFromWebHandle(std::move(handle))); |
@@ -451,7 +452,7 @@ TEST_F(BodyStreamBufferTest, LoaderShouldBeKeptAliveByBodyStreamBuffer) |
EXPECT_CALL(*client, didFetchDataLoadedString(String("hello"))); |
EXPECT_CALL(checkpoint, Call(2)); |
- OwnPtr<ReplayingHandle> handle = ReplayingHandle::create(); |
+ std::unique_ptr<ReplayingHandle> handle = ReplayingHandle::create(); |
handle->add(Command(Command::Data, "hello")); |
handle->add(Command(Command::Done)); |
Persistent<BodyStreamBuffer> buffer = new BodyStreamBuffer(getScriptState(), createFetchDataConsumerHandleFromWebHandle(std::move(handle))); |
@@ -466,7 +467,7 @@ TEST_F(BodyStreamBufferTest, LoaderShouldBeKeptAliveByBodyStreamBuffer) |
// TODO(hiroshige): Merge this class into MockFetchDataConsumerHandle. |
class MockFetchDataConsumerHandleWithMockDestructor : public DataConsumerHandleTestUtil::MockFetchDataConsumerHandle { |
public: |
- static PassOwnPtr<::testing::StrictMock<MockFetchDataConsumerHandleWithMockDestructor>> create() { return adoptPtr(new ::testing::StrictMock<MockFetchDataConsumerHandleWithMockDestructor>); } |
+ static std::unique_ptr<::testing::StrictMock<MockFetchDataConsumerHandleWithMockDestructor>> create() { return wrapUnique(new ::testing::StrictMock<MockFetchDataConsumerHandleWithMockDestructor>); } |
~MockFetchDataConsumerHandleWithMockDestructor() override |
{ |
@@ -481,8 +482,8 @@ TEST_F(BodyStreamBufferTest, SourceHandleAndReaderShouldBeDestructedWhenCanceled |
ScriptState::Scope scope(getScriptState()); |
using MockHandle = MockFetchDataConsumerHandleWithMockDestructor; |
using MockReader = DataConsumerHandleTestUtil::MockFetchDataConsumerReader; |
- OwnPtr<MockHandle> handle = MockHandle::create(); |
- OwnPtr<MockReader> reader = MockReader::create(); |
+ std::unique_ptr<MockHandle> handle = MockHandle::create(); |
+ std::unique_ptr<MockReader> reader = MockReader::create(); |
Checkpoint checkpoint; |
InSequence s; |
@@ -494,7 +495,7 @@ TEST_F(BodyStreamBufferTest, SourceHandleAndReaderShouldBeDestructedWhenCanceled |
EXPECT_CALL(checkpoint, Call(2)); |
// |reader| is adopted by |obtainReader|. |
- ASSERT_TRUE(reader.leakPtr()); |
+ ASSERT_TRUE(reader.release()); |
BodyStreamBuffer* buffer = new BodyStreamBuffer(getScriptState(), std::move(handle)); |
checkpoint.Call(1); |