third_party/WebKit/Source/modules/encoding/TextDecoder.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/encoding/TextDecoder.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/encoding/TextDecoder.h

diff --git a/third_party/WebKit/Source/modules/encoding/TextDecoder.h b/third_party/WebKit/Source/modules/encoding/TextDecoder.h

index ccbab4dc6792058de37d0a478d59a90d1ab5a1d2..5118a26bf10b91143c38778286d82f2133f03e26 100644

--- a/third_party/WebKit/Source/modules/encoding/TextDecoder.h

+++ b/third_party/WebKit/Source/modules/encoding/TextDecoder.h

@@ -39,6 +39,7 @@

#include "wtf/text/TextCodec.h"

#include "wtf/text/TextEncoding.h"

#include "wtf/text/WTFString.h"

+#include <memory>

namespace blink {

@@ -67,7 +68,7 @@ private:

String decode(const char* start, size_t length, const TextDecodeOptions&, ExceptionState&);

WTF::TextEncoding m_encoding;

- OwnPtr<WTF::TextCodec> m_codec;

+ std::unique_ptr<WTF::TextCodec> m_codec;

bool m_fatal;

bool m_ignoreBOM;

bool m_bomSeen;