third_party/WebKit/Source/core/css/MediaQuery.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/MediaQuery.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/MediaQuery.cpp

diff --git a/third_party/WebKit/Source/core/css/MediaQuery.cpp b/third_party/WebKit/Source/core/css/MediaQuery.cpp

index f440b1c1ced5ca7780bfc08086457829c985638d..6ba95d15a3bbec05a5832f17ec90da69d492854f 100644

--- a/third_party/WebKit/Source/core/css/MediaQuery.cpp

+++ b/third_party/WebKit/Source/core/css/MediaQuery.cpp

@@ -33,6 +33,7 @@

#include "core/html/parser/HTMLParserIdioms.h"

#include "wtf/NonCopyingSort.h"

#include "wtf/text/StringBuilder.h"

+#include <memory>

namespace blink {

@@ -134,7 +135,7 @@ String MediaQuery::cssText() const

DEFINE_TRACE(MediaQuery)

{

- // We don't support tracing of vectors of OwnPtrs (ie. OwnPtr<Vector<OwnPtr<MediaQuery>>>).

+ // We don't support tracing of vectors of OwnPtrs (ie. std::unique_ptr<Vector<std::unique_ptr<MediaQuery>>>).

// Since this is a transitional object we are just ifdef'ing it out when oilpan is not enabled.

visitor->trace(m_expressions);

}