third_party/WebKit/Source/wtf/text/TextEncodingRegistry.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/TextEncodingRegistry.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/TextEncodingRegistry.h

diff --git a/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.h b/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.h

index 6b8a2f19738900a2408ace6aa518cce22fbdb116..c6d0efd4b154b3bceee7649876fb83049fc0bdac 100644

--- a/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.h

+++ b/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.h

@@ -26,10 +26,10 @@

#ifndef TextEncodingRegistry_h

#define TextEncodingRegistry_h

-#include "wtf/PassOwnPtr.h"

#include "wtf/WTFExport.h"

#include "wtf/text/Unicode.h"

#include "wtf/text/WTFString.h"

+#include <memory>

namespace WTF {

@@ -38,7 +38,7 @@ class TextEncoding;

// Use TextResourceDecoder::decode to decode resources, since it handles BOMs.

// Use TextEncoding::encode to encode, since it takes care of normalization.

-WTF_EXPORT PassOwnPtr<TextCodec> newTextCodec(const TextEncoding&);

+WTF_EXPORT std::unique_ptr<TextCodec> newTextCodec(const TextEncoding&);

// Only TextEncoding should use the following functions directly.

const char* atomicCanonicalTextEncodingName(const char* alias);