Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: First attempt to land. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
index 2661227470ac0759f7b83803a1774adbb0116511..b06ec4fdf91d9ba1d652a6d699302a08db4a9657 100644
--- a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
@@ -19,6 +19,8 @@
#include "public/platform/WebTaskRunner.h"
#include "public/platform/WebThread.h"
#include "wtf/Functional.h"
+#include "wtf/PtrUtil.h"
+#include <memory>
namespace blink {
@@ -26,9 +28,9 @@ static const unsigned maxReportedHandlersPendingResolution = 1000;
class RejectedPromises::Message final {
public:
- static PassOwnPtr<Message> create(ScriptState* scriptState, v8::Local<v8::Promise> promise, v8::Local<v8::Value> exception, const String& errorMessage, PassOwnPtr<SourceLocation> location, AccessControlStatus corsStatus)
+ static std::unique_ptr<Message> create(ScriptState* scriptState, v8::Local<v8::Promise> promise, v8::Local<v8::Value> exception, const String& errorMessage, std::unique_ptr<SourceLocation> location, AccessControlStatus corsStatus)
{
- return adoptPtr(new Message(scriptState, promise, exception, errorMessage, std::move(location), corsStatus));
+ return wrapUnique(new Message(scriptState, promise, exception, errorMessage, std::move(location), corsStatus));
}
bool isCollected()
@@ -145,7 +147,7 @@ public:
}
private:
- Message(ScriptState* scriptState, v8::Local<v8::Promise> promise, v8::Local<v8::Value> exception, const String& errorMessage, PassOwnPtr<SourceLocation> location, AccessControlStatus corsStatus)
+ Message(ScriptState* scriptState, v8::Local<v8::Promise> promise, v8::Local<v8::Value> exception, const String& errorMessage, std::unique_ptr<SourceLocation> location, AccessControlStatus corsStatus)
: m_scriptState(scriptState)
, m_promise(scriptState->isolate(), promise)
, m_exception(scriptState->isolate(), exception)
@@ -175,7 +177,7 @@ private:
ScopedPersistent<v8::Value> m_exception;
String m_errorMessage;
String m_resourceName;
- OwnPtr<SourceLocation> m_location;
+ std::unique_ptr<SourceLocation> m_location;
unsigned m_consoleMessageId;
bool m_collected;
bool m_shouldLogToConsole;
@@ -190,7 +192,7 @@ RejectedPromises::~RejectedPromises()
{
}
-void RejectedPromises::rejectedWithNoHandler(ScriptState* scriptState, v8::PromiseRejectMessage data, const String& errorMessage, PassOwnPtr<SourceLocation> location, AccessControlStatus corsStatus)
+void RejectedPromises::rejectedWithNoHandler(ScriptState* scriptState, v8::PromiseRejectMessage data, const String& errorMessage, std::unique_ptr<SourceLocation> location, AccessControlStatus corsStatus)
{
m_queue.append(Message::create(scriptState, data.GetPromise(), data.GetValue(), errorMessage, std::move(location), corsStatus));
}
@@ -207,19 +209,19 @@ void RejectedPromises::handlerAdded(v8::PromiseRejectMessage data)
// Then look it up in the reported errors.
for (size_t i = 0; i < m_reportedAsErrors.size(); ++i) {
- OwnPtr<Message>& message = m_reportedAsErrors.at(i);
+ std::unique_ptr<Message>& message = m_reportedAsErrors.at(i);
if (!message->isCollected() && message->hasPromise(data.GetPromise())) {
message->makePromiseStrong();
- Platform::current()->currentThread()->scheduler()->timerTaskRunner()->postTask(BLINK_FROM_HERE, bind(&RejectedPromises::revokeNow, this, passed(std::move(message))));
+ Platform::current()->currentThread()->scheduler()->timerTaskRunner()->postTask(BLINK_FROM_HERE, WTF::bind(&RejectedPromises::revokeNow, this, passed(std::move(message))));
m_reportedAsErrors.remove(i);
return;
}
}
}
-PassOwnPtr<RejectedPromises::MessageQueue> RejectedPromises::createMessageQueue()
+std::unique_ptr<RejectedPromises::MessageQueue> RejectedPromises::createMessageQueue()
{
- return adoptPtr(new MessageQueue());
+ return wrapUnique(new MessageQueue());
}
void RejectedPromises::dispose()
@@ -227,7 +229,7 @@ void RejectedPromises::dispose()
if (m_queue.isEmpty())
return;
- OwnPtr<MessageQueue> queue = createMessageQueue();
+ std::unique_ptr<MessageQueue> queue = createMessageQueue();
queue->swap(m_queue);
processQueueNow(std::move(queue));
}
@@ -237,12 +239,12 @@ void RejectedPromises::processQueue()
if (m_queue.isEmpty())
return;
- OwnPtr<MessageQueue> queue = createMessageQueue();
+ std::unique_ptr<MessageQueue> queue = createMessageQueue();
queue->swap(m_queue);
- Platform::current()->currentThread()->scheduler()->timerTaskRunner()->postTask(BLINK_FROM_HERE, bind(&RejectedPromises::processQueueNow, PassRefPtr<RejectedPromises>(this), passed(std::move(queue))));
+ Platform::current()->currentThread()->scheduler()->timerTaskRunner()->postTask(BLINK_FROM_HERE, WTF::bind(&RejectedPromises::processQueueNow, PassRefPtr<RejectedPromises>(this), passed(std::move(queue))));
}
-void RejectedPromises::processQueueNow(PassOwnPtr<MessageQueue> queue)
+void RejectedPromises::processQueueNow(std::unique_ptr<MessageQueue> queue)
{
// Remove collected handlers.
for (size_t i = 0; i < m_reportedAsErrors.size();) {
@@ -253,7 +255,7 @@ void RejectedPromises::processQueueNow(PassOwnPtr<MessageQueue> queue)
}
while (!queue->isEmpty()) {
- OwnPtr<Message> message = queue->takeFirst();
+ std::unique_ptr<Message> message = queue->takeFirst();
if (message->isCollected())
continue;
if (!message->hasHandler()) {
@@ -266,7 +268,7 @@ void RejectedPromises::processQueueNow(PassOwnPtr<MessageQueue> queue)
}
}
-void RejectedPromises::revokeNow(PassOwnPtr<Message> message)
+void RejectedPromises::revokeNow(std::unique_ptr<Message> message)
{
message->revoke();
}

Powered by Google App Engine
This is Rietveld 408576698