third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/SQLTransaction.h ('k') | third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h

diff --git a/third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h b/third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h

index c3504d8d860bd70eca56868d17389e5a2a1b5965..989d73392083d2385bd86923892dcd347fd1db97 100644

--- a/third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h

+++ b/third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h

@@ -35,6 +35,7 @@

#include "wtf/Deque.h"

#include "wtf/Forward.h"

#include "wtf/ThreadingPrimitives.h"

+#include <memory>

namespace blink {

@@ -110,7 +111,7 @@ private:

Member<Database> m_database;

Member<SQLTransactionWrapper> m_wrapper;

- OwnPtr<SQLErrorData> m_transactionError;

+ std::unique_ptr<SQLErrorData> m_transactionError;

bool m_hasCallback;

bool m_hasSuccessCallback;

@@ -124,7 +125,7 @@ private:

Mutex m_statementMutex;

Deque<CrossThreadPersistent<SQLStatementBackend>> m_statementQueue;

- OwnPtr<SQLiteTransaction> m_sqliteTransaction;

+ std::unique_ptr<SQLiteTransaction> m_sqliteTransaction;

};

} // namespace blink