third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

index 2aa2cdc3f5b2fa2f2c1a9909b9efde5e442f842b..4b0a07f269e3e148bd5df1d3b85e439694357664 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

@@ -11,9 +11,9 @@

#include "core/CoreExport.h"

#include "core/dom/ContextLifecycleObserver.h"

#include "wtf/Compiler.h"

-#include "wtf/OwnPtr.h"

#include "wtf/RefCounted.h"

#include "wtf/Vector.h"

+#include <memory>

#include <v8.h>

namespace blink {

@@ -63,7 +63,7 @@ protected:

NEVER_INLINE void resetBase();

private:

- typedef Vector<OwnPtr<ScopedPersistent<v8::Object>>> WeakPersistentSet;

+ typedef Vector<std::unique_ptr<ScopedPersistent<v8::Object>>> WeakPersistentSet;

void resolveOrRejectInternal(v8::Local<v8::Promise::Resolver>);

v8::Local<v8::Object> ensureHolderWrapper(ScriptState*);