third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp ('k') | third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

index 4326fd380bc7020672cd85d65baff7b28936a218..7455b24111b1083bb518658bd7635f4e908f89e1 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

@@ -7,6 +7,7 @@

#include "core/html/parser/PreloadRequest.h"

#include "core/testing/DummyPageHolder.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include <memory>

namespace blink {

@@ -53,7 +54,7 @@ protected:

{

// TODO(yoav): Need a mock loader here to verify things are happenning beyond preconnect.

PreloaderNetworkHintsMock networkHints;

- OwnPtr<PreloadRequest> preloadRequest = PreloadRequest::create(String(),

+ std::unique_ptr<PreloadRequest> preloadRequest = PreloadRequest::create(String(),

TextPosition(),

testCase.url,

KURL(ParsedURLStringTag(), testCase.baseURL),

@@ -72,7 +73,7 @@ protected:

}

private:

- OwnPtr<DummyPageHolder> m_dummyPageHolder;

+ std::unique_ptr<DummyPageHolder> m_dummyPageHolder;

};

TEST_F(HTMLResourcePreloaderTest, testPreconnect)