Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: third_party/WebKit/Source/modules/webdatabase/Database.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: First attempt to land. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webdatabase/Database.cpp
diff --git a/third_party/WebKit/Source/modules/webdatabase/Database.cpp b/third_party/WebKit/Source/modules/webdatabase/Database.cpp
index 2f3177751e8bdb7a7fa83bdf7858010c4127062d..101fb0a7b21af45f5f68549c1e759ef4c55e4669 100644
--- a/third_party/WebKit/Source/modules/webdatabase/Database.cpp
+++ b/third_party/WebKit/Source/modules/webdatabase/Database.cpp
@@ -55,6 +55,7 @@
#include "public/platform/WebSecurityOrigin.h"
#include "wtf/Atomics.h"
#include "wtf/CurrentTime.h"
+#include <memory>
// Registering "opened" databases with the DatabaseTracker
// =======================================================
@@ -265,7 +266,7 @@ bool Database::openAndVerifyVersion(bool setVersionInNewDatabase, DatabaseError&
DatabaseTracker::tracker().prepareToOpenDatabase(this);
bool success = false;
- OwnPtr<DatabaseOpenTask> task = DatabaseOpenTask::create(this, setVersionInNewDatabase, &synchronizer, error, errorMessage, success);
+ std::unique_ptr<DatabaseOpenTask> task = DatabaseOpenTask::create(this, setVersionInNewDatabase, &synchronizer, error, errorMessage, success);
getDatabaseContext()->databaseThread()->scheduleTask(std::move(task));
synchronizer.waitForTaskCompletion();
@@ -331,7 +332,7 @@ void Database::scheduleTransaction()
transaction = m_transactionQueue.takeFirst();
if (transaction && getDatabaseContext()->databaseThreadAvailable()) {
- OwnPtr<DatabaseTransactionTask> task = DatabaseTransactionTask::create(transaction);
+ std::unique_ptr<DatabaseTransactionTask> task = DatabaseTransactionTask::create(transaction);
WTF_LOG(StorageAPI, "Scheduling DatabaseTransactionTask %p for transaction %p\n", task.get(), task->transaction());
m_transactionInProgress = true;
getDatabaseContext()->databaseThread()->scheduleTask(std::move(task));
@@ -345,7 +346,7 @@ void Database::scheduleTransactionStep(SQLTransactionBackend* transaction)
if (!getDatabaseContext()->databaseThreadAvailable())
return;
- OwnPtr<DatabaseTransactionTask> task = DatabaseTransactionTask::create(transaction);
+ std::unique_ptr<DatabaseTransactionTask> task = DatabaseTransactionTask::create(transaction);
WTF_LOG(StorageAPI, "Scheduling DatabaseTransactionTask %p for the transaction step\n", task.get());
getDatabaseContext()->databaseThread()->scheduleTask(std::move(task));
}
@@ -809,7 +810,7 @@ void Database::readTransaction(
runTransaction(callback, errorCallback, successCallback, true);
}
-static void callTransactionErrorCallback(SQLTransactionErrorCallback* callback, PassOwnPtr<SQLErrorData> errorData)
+static void callTransactionErrorCallback(SQLTransactionErrorCallback* callback, std::unique_ptr<SQLErrorData> errorData)
{
callback->handleEvent(SQLError::create(*errorData));
}
@@ -835,7 +836,7 @@ void Database::runTransaction(
SQLTransactionErrorCallback* callback = transaction->releaseErrorCallback();
ASSERT(callback == originalErrorCallback);
if (callback) {
- OwnPtr<SQLErrorData> error = SQLErrorData::create(SQLError::UNKNOWN_ERR, "database has been closed");
+ std::unique_ptr<SQLErrorData> error = SQLErrorData::create(SQLError::UNKNOWN_ERR, "database has been closed");
getExecutionContext()->postTask(BLINK_FROM_HERE, createSameThreadTask(&callTransactionErrorCallback, callback, passed(std::move(error))));
}
}
@@ -887,7 +888,7 @@ Vector<String> Database::tableNames()
if (!getDatabaseContext()->databaseThreadAvailable())
return result;
- OwnPtr<DatabaseTableNamesTask> task = DatabaseTableNamesTask::create(this, &synchronizer, result);
+ std::unique_ptr<DatabaseTableNamesTask> task = DatabaseTableNamesTask::create(this, &synchronizer, result);
getDatabaseContext()->databaseThread()->scheduleTask(std::move(task));
synchronizer.waitForTaskCompletion();

Powered by Google App Engine
This is Rietveld 408576698