Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: third_party/WebKit/Source/core/animation/EffectInputTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/animation/EffectInput.h" 5 #include "core/animation/EffectInput.h"
6 6
7 #include "bindings/core/v8/Dictionary.h" 7 #include "bindings/core/v8/Dictionary.h"
8 #include "bindings/core/v8/EffectModelOrDictionarySequenceOrDictionary.h" 8 #include "bindings/core/v8/EffectModelOrDictionarySequenceOrDictionary.h"
9 #include "bindings/core/v8/V8BindingForTesting.h" 9 #include "bindings/core/v8/V8BindingForTesting.h"
10 #include "core/animation/AnimationTestHelper.h" 10 #include "core/animation/AnimationTestHelper.h"
11 #include "core/animation/KeyframeEffectModel.h" 11 #include "core/animation/KeyframeEffectModel.h"
12 #include "core/dom/Document.h" 12 #include "core/dom/Document.h"
13 #include "core/dom/Element.h" 13 #include "core/dom/Element.h"
14 #include "core/dom/ExceptionCode.h" 14 #include "core/dom/ExceptionCode.h"
15 #include "core/testing/DummyPageHolder.h" 15 #include "core/testing/DummyPageHolder.h"
16 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
17 #include <memory>
17 #include <v8.h> 18 #include <v8.h>
18 19
19 namespace blink { 20 namespace blink {
20 21
21 class AnimationEffectInputTest : public ::testing::Test { 22 class AnimationEffectInputTest : public ::testing::Test {
22 protected: 23 protected:
23 AnimationEffectInputTest() 24 AnimationEffectInputTest()
24 : pageHolder(DummyPageHolder::create()) 25 : pageHolder(DummyPageHolder::create())
25 , element(pageHolder->document().createElement("foo", ASSERT_NO_EXCEPTIO N)) 26 , element(pageHolder->document().createElement("foo", ASSERT_NO_EXCEPTIO N))
26 , m_isolate(v8::Isolate::GetCurrent()) 27 , m_isolate(v8::Isolate::GetCurrent())
27 , m_scope(m_isolate) 28 , m_scope(m_isolate)
28 { 29 {
29 pageHolder->document().documentElement()->appendChild(element.get()); 30 pageHolder->document().documentElement()->appendChild(element.get());
30 } 31 }
31 32
32 OwnPtr<DummyPageHolder> pageHolder; 33 std::unique_ptr<DummyPageHolder> pageHolder;
33 Persistent<Element> element; 34 Persistent<Element> element;
34 TrackExceptionState exceptionState; 35 TrackExceptionState exceptionState;
35 v8::Isolate* m_isolate; 36 v8::Isolate* m_isolate;
36 37
37 private: 38 private:
38 V8TestingScope m_scope; 39 V8TestingScope m_scope;
39 }; 40 };
40 41
41 TEST_F(AnimationEffectInputTest, SortedOffsets) 42 TEST_F(AnimationEffectInputTest, SortedOffsets)
42 { 43 {
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 jsKeyframes.append(Dictionary(keyframe1, m_isolate, exceptionState)); 143 jsKeyframes.append(Dictionary(keyframe1, m_isolate, exceptionState));
143 jsKeyframes.append(Dictionary(keyframe2, m_isolate, exceptionState)); 144 jsKeyframes.append(Dictionary(keyframe2, m_isolate, exceptionState));
144 jsKeyframes.append(Dictionary(keyframe3, m_isolate, exceptionState)); 145 jsKeyframes.append(Dictionary(keyframe3, m_isolate, exceptionState));
145 146
146 EffectInput::convert(element.get(), EffectModelOrDictionarySequenceOrDiction ary::fromDictionarySequence(jsKeyframes), nullptr, exceptionState); 147 EffectInput::convert(element.get(), EffectModelOrDictionarySequenceOrDiction ary::fromDictionarySequence(jsKeyframes), nullptr, exceptionState);
147 EXPECT_TRUE(exceptionState.hadException()); 148 EXPECT_TRUE(exceptionState.hadException());
148 EXPECT_EQ(V8TypeError, exceptionState.code()); 149 EXPECT_EQ(V8TypeError, exceptionState.code());
149 } 150 }
150 151
151 } // namespace blink 152 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698