pkg/analyzer/lib/file_system/memory_file_system.dart - Issue 2050083002: Fix equality between subclasses of Source

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/file_system/memory_file_system.dart

Issue 2050083002: Fix equality between subclasses of Source (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/file_system/memory_file_system.dart

diff --git a/pkg/analyzer/lib/file_system/memory_file_system.dart b/pkg/analyzer/lib/file_system/memory_file_system.dart

index 3ec640e9a5b1bfa6e0a561ff489e92374f6aaf04..143e7191e80bcfc0b365e7dc27647f42f4be94f8 100644

--- a/pkg/analyzer/lib/file_system/memory_file_system.dart

+++ b/pkg/analyzer/lib/file_system/memory_file_system.dart

@@ -449,7 +449,12 @@ class _MemoryFileSource extends Source {

@override

bool operator ==(other) {

- return other is _MemoryFileSource && other.id == id;

+ if (other is _MemoryFileSource) {

+ return id == other.id;

+ } else if (other is Source) {

+ return uri == other.uri;

+ }

+ return false;

}

@override