Issue 2050083002: Fix equality between subclasses of Source

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2050083002: Fix equality between subclasses of Source (Closed)

Created:
4 years, 6 months ago by Brian Wilkerson

Modified:
4 years, 6 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -9 lines)			Patch
M	pkg/analysis_server/test/services/completion/dart/optype_test.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/file_system/memory_file_system.dart	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/source_io.dart	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/package_bundle_reader.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/analyzer/test/generated/test_support.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	pkg/analyzer/test/src/context/context_test.dart	View	1 chunk	+9 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

As noted in an e-mail thread, FileBasedSource and InSummarySource would not compare as equal even ...

4 years, 6 months ago (2016-06-09 03:58:10 UTC) #2

Brian Wilkerson

4 years, 6 months ago (2016-06-09 14:42:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f183ec3a4520fea9c94d16779221b0370fb042df (presubmit successful).