Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2050053005: [som] Add bugqueue handler to fetch Sheriff-* issues from monorail. (Closed)

Created:
4 years, 6 months ago by seanmccullough1
Modified:
4 years, 6 months ago
Reviewers:
martiniss
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[som] Add bugqueue handler to fetch Sheriff-* issues from monorail. BUG=618434 Committed: https://chromium.googlesource.com/infra/infra/+/ae8ea9e4c52c06194a70157687f30d039fdd049d

Patch Set 1 #

Patch Set 2 : errors, endpoint str #

Total comments: 2

Patch Set 3 : lucify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M go/src/infra/appengine/sheriff-o-matic/main.go View 1 2 5 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
seanmccullough1
4 years, 6 months ago (2016-06-09 18:30:48 UTC) #2
martiniss
https://codereview.chromium.org/2050053005/diff/20001/go/src/infra/appengine/sheriff-o-matic/main.go File go/src/infra/appengine/sheriff-o-matic/main.go (right): https://codereview.chromium.org/2050053005/diff/20001/go/src/infra/appengine/sheriff-o-matic/main.go#newcode21 go/src/infra/appengine/sheriff-o-matic/main.go:21: "google.golang.org/appengine/urlfetch" You should use https://godoc.org/github.com/luci/luci-go/appengine/gaeauth/client instead, since that allows ...
4 years, 6 months ago (2016-06-09 18:36:07 UTC) #3
seanmccullough1
https://codereview.chromium.org/2050053005/diff/20001/go/src/infra/appengine/sheriff-o-matic/main.go File go/src/infra/appengine/sheriff-o-matic/main.go (right): https://codereview.chromium.org/2050053005/diff/20001/go/src/infra/appengine/sheriff-o-matic/main.go#newcode21 go/src/infra/appengine/sheriff-o-matic/main.go:21: "google.golang.org/appengine/urlfetch" On 2016/06/09 18:36:07, martiniss wrote: > You should ...
4 years, 6 months ago (2016-06-09 19:02:58 UTC) #4
martiniss
lgtm
4 years, 6 months ago (2016-06-09 19:11:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050053005/40001
4 years, 6 months ago (2016-06-09 19:16:53 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 19:53:48 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/ae8ea9e4c52c06194a70157687f30...

Powered by Google App Engine
This is Rietveld 408576698