MD Settings: split browser tests per-file

chrome/test/data/webui/settings/cr_settings_browsertest.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Runs the Polymer Settings tests. */
 
 /** @const {string} Path to source root. */
 var ROOT_PATH = '../../../../../';
 
 // Polymer BrowserTest fixture.
 GEN_INCLUDE(
     [ROOT_PATH + 'chrome/test/data/webui/polymer_browser_test_base.js']);
 
 /**
  * Test fixture for Polymer Settings elements.
  * @constructor
  * @extends {PolymerTest}
 */
 function CrSettingsBrowserTest() {}
 
 CrSettingsBrowserTest.prototype = {
   __proto__: PolymerTest.prototype,
 
   /** @override */
-  browsePreload: 'chrome://md-settings/prefs/prefs.html',
+  browsePreload: 'about:inducebrowsercrashforrealz',

[michaelpg, 2016/06/15 02:31:48]

comment on the point of this

[Dan Beam, 2016/06/15 05:52:34]

Done.

 
-  /**
-   * TODO(dbeam): these should not be required monolithically.
-   * @override
-   */
-  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
-    '../fake_chrome_event.js',
-    'fake_settings_private.js',
-    'checkbox_tests.js',
-    'dropdown_menu_tests.js',
-    'pref_util_tests.js',
-    'prefs_test_cases.js',
-    'prefs_tests.js',
-  ]),
+  /** @override */
+  extraLibraries: PolymerTest.getLibraries(ROOT_PATH),
 
   /** @override */
   setUp: function() {
     PolymerTest.prototype.setUp.call(this);
     // We aren't loading the main document.
     this.accessibilityAuditConfig.ignoreSelectors('humanLangMissing', 'html');
 
     // TODO(michaelpg): Re-enable after bringing in fix for
     // https://github.com/PolymerElements/paper-slider/issues/131.
     this.accessibilityAuditConfig.ignoreSelectors(
         'badAriaAttributeValue', 'paper-slider');
   },
 };
 
 // Have to include command_line.h manually due to GEN calls below.
 GEN('#include "base/command_line.h"');
 
-TEST_F('CrSettingsBrowserTest', 'Checkbox', function() {
+function CrSettingsCheckboxTest() {}
+
+CrSettingsCheckboxTest.prototype = {
+  __proto__: CrSettingsBrowserTest.prototype,
+
+  /** @override */
+  browsePreload: 'chrome://md-settings/controls/settings_checkbox.html',
+
+  /** @override */
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
+    'checkbox_tests.js',
+  ]),
+};
+
+TEST_F('CrSettingsCheckboxTest', 'All', function() {
   settings_checkbox.registerTests();
   mocha.run();
 });
 
-TEST_F('CrSettingsBrowserTest', 'DropdownMenu', function() {
+function CrSettingsDropdownMenuTest() {}
+
+CrSettingsDropdownMenuTest.prototype = {
+  __proto__: CrSettingsBrowserTest.prototype,
+
+  /** @override */
+  browsePreload: 'chrome://md-settings/controls/settings_dropdown_menu.html',
+
+  /** @override */
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
+    'dropdown_menu_tests.js',
+  ]),
+};
+
+TEST_F('CrSettingsDropdownMenuTest', 'All', function() {
   settings_dropdown_menu.registerTests();
   mocha.run();
 });
 
-TEST_F('CrSettingsBrowserTest', 'PrefUtil', function() {
+function CrSettingsPrefUtilTest() {}
+
+CrSettingsPrefUtilTest.prototype = {
+  __proto__: CrSettingsBrowserTest.prototype,
+
+  /** @override */
+  browsePreload: 'chrome://md-settings/prefs/pref_util.html',
+
+  /** @override */
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
+    'pref_util_tests.js',
+  ]),
+};
+
+TEST_F('CrSettingsPrefUtilTest', 'All', function() {
   settings_prefUtil.registerTests();
   mocha.run();
 });
 
-TEST_F('CrSettingsBrowserTest', 'Prefs', function() {
+function CrSettingsPrefsTest() {}
+
+CrSettingsPrefsTest.prototype = {
+  __proto__: CrSettingsBrowserTest.prototype,
+
+  /** @override */
+  browsePreload: 'chrome://md-settings/prefs/prefs.html',
+
+  /** @override */
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
+    '../fake_chrome_event.js',
+    'fake_settings_private.js',
+    'prefs_test_cases.js',
+    'prefs_tests.js',
+  ]),
+};
+
+TEST_F('CrSettingsPrefsTest', 'All', function() {
   settings_prefs.registerTests();
   mocha.run();
 });
 
 /**
  * @constructor
  * @extends {CrSettingsBrowserTest}
  */
 function CrSettingsAboutPageTest() {}
 
@@ skipping 32 matching lines @@
 */
 function CrSettingsPeoplePageChangePictureTest() {}
 
 CrSettingsPeoplePageChangePictureTest.prototype = {
   __proto__: CrSettingsBrowserTest.prototype,
 
   /** @override */
   browsePreload: 'chrome://md-settings/people_page/change_picture.html',
 
   /** @override */
-  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
     'test_browser_proxy.js',
     'people_page_change_picture_test.js',
   ]),
 };
 
 TEST_F('CrSettingsPeoplePageChangePictureTest', 'ChangePicture', function() {
   settings_people_page_change_picture.registerTests();
   mocha.run();
 });
 GEN('#else');  // !defined(OS_CHROMEOS)
 /**
  * Test fixture for
  * chrome/browser/resources/settings/people_page/manage_profile.html.
  * This is non-ChromeOS only.
  * @constructor
  * @extends {CrSettingsBrowserTest}
 */
 function CrSettingsPeoplePageManageProfileTest() {}
 
 CrSettingsPeoplePageManageProfileTest.prototype = {
   __proto__: CrSettingsBrowserTest.prototype,
 
   /** @override */
   browsePreload: 'chrome://md-settings/people_page/manage_profile.html',
 
   /** @override */
-  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
     'test_browser_proxy.js',
     'people_page_manage_profile_test.js',
   ]),
 };
 
 TEST_F('CrSettingsPeoplePageManageProfileTest', 'ManageProfile', function() {
   settings_people_page_manage_profile.registerTests();
   mocha.run();
 });
 GEN('#endif');
 
 /**
  * Test fixture for
  * chrome/browser/resources/settings/people_page/people_page.html.
  * @constructor
  * @extends {CrSettingsBrowserTest}
 */
 function CrSettingsPeoplePageTest() {}
 
 CrSettingsPeoplePageTest.prototype = {
   __proto__: CrSettingsBrowserTest.prototype,
 
   /** @override */
   browsePreload: 'chrome://md-settings/people_page/people_page.html',
 
   /** @override */
-  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
     'test_browser_proxy.js',
     'people_page_test.js',
   ]),
 };
 
 TEST_F('CrSettingsPeoplePageTest', 'PeoplePage', function() {
   settings_people_page.registerTests();
   mocha.run();
 });
 
 /**
  * Test fixture for
  * chrome/browser/resources/settings/people_page/sync_page.html.
  * @constructor
  * @extends {CrSettingsBrowserTest}
 */
 function CrSettingsPeoplePageSyncPageTest() {}
 
 CrSettingsPeoplePageSyncPageTest.prototype = {
   __proto__: CrSettingsBrowserTest.prototype,
 
   /** @override */
   browsePreload: 'chrome://md-settings/people_page/sync_page.html',
 
   /** @override */
-  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
     'test_browser_proxy.js',
     'people_page_sync_page_test.js',
   ]),
 };
 
 TEST_F('CrSettingsPeoplePageSyncPageTest', 'SyncPage', function() {
   settings_people_page_sync_page.registerTests();
   mocha.run();
 });
 
@@ skipping 28 matching lines @@
 */
 function CrSettingsResetPageTest() {}
 
 CrSettingsResetPageTest.prototype = {
   __proto__: CrSettingsBrowserTest.prototype,
 
   /** @override */
   browsePreload: 'chrome://md-settings/reset_page/reset_page.html',
 
   /** @override */
-  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
     'test_browser_proxy.js',
     'test_lifetime_browser_proxy.js',
     'reset_page_test.js',
   ]),
 };
 
 TEST_F('CrSettingsResetPageTest', 'ResetPage', function() {
   settings_reset_page.registerTests();
   mocha.run();
 });
 
 /**
  * Test fixture for chrome/browser/resources/settings/appearance_page/.
  * @constructor
  * @extends {CrSettingsBrowserTest}
 */
 function CrSettingsAppearancePageTest() {}
 
 CrSettingsAppearancePageTest.prototype = {
   __proto__: CrSettingsBrowserTest.prototype,
 
   /** @override */
   browsePreload: 'chrome://md-settings/appearance_page/appearance_page.html',
 
   /** @override */
-  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
     ROOT_PATH + 'ui/webui/resources/js/promise_resolver.js',
     'test_browser_proxy.js',
     'appearance_page_test.js',
   ]),
 };
 
 TEST_F('CrSettingsAppearancePageTest', 'AppearancePage', function() {
   settings_appearance.registerTests();
   mocha.run();
 });
 
 /**
  * Test fixture for chrome/browser/resources/settings/search_page/.
  * @constructor
  * @extends {CrSettingsBrowserTest}
 */
 function CrSettingsSearchPageTest() {}
 
 CrSettingsSearchPageTest.prototype = {
   __proto__: CrSettingsBrowserTest.prototype,
 
   /** @override */
   browsePreload: 'chrome://md-settings/search_page/search_page.html',
 
   /** @override */
-  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
     'test_browser_proxy.js',
     'test_search_engines_browser_proxy.js',
     'search_page_test.js',
   ]),
 };
 
 TEST_F('CrSettingsSearchPageTest', 'SearchPage', function() {
   settings_search_page.registerTests();
   mocha.run();
 });
 
 /**
  * Test fixture for chrome/browser/resources/settings/search_engines_page/.
  * @constructor
  * @extends {CrSettingsBrowserTest}
 */
 function CrSettingsSearchEnginesTest() {}
 
 CrSettingsSearchEnginesTest.prototype = {
   __proto__: CrSettingsBrowserTest.prototype,
 
   /** @override */
   browsePreload:
       'chrome://md-settings/search_engines_page/search_engines_page.html',
 
   /** @override */
-  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
     'test_browser_proxy.js',
     'test_search_engines_browser_proxy.js',
     'search_engines_page_test.js',
   ]),
 };
 
 TEST_F('CrSettingsSearchEnginesTest', 'SearchEngines', function() {
   settings_search_engines_page.registerTests();
   mocha.run();
 });
 
 GEN('#if defined(USE_NSS_CERTS)');
 /**
  * Test fixture for chrome/browser/resources/settings/certificate_manager_page/.
  * @constructor
  * @extends {CrSettingsBrowserTest}
 */
 function CrSettingsCertificateManagerTest() {}
 
 CrSettingsCertificateManagerTest.prototype = {
   __proto__: CrSettingsBrowserTest.prototype,
 
   /** @override */
   browsePreload: 'chrome://md-settings/certificate_manager_page/' +
       'certificate_manager_page.html',
 
   /** @override */
-  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
     'test_browser_proxy.js',
     'certificate_manager_page_test.js',
   ]),
 };
 
 TEST_F('CrSettingsCertificateManagerTest', 'CertificateManager', function() {
   certificate_manager_page.registerTests();
   mocha.run();
 });
 GEN('#endif');
 
 /**
  * Test fixture for chrome/browser/resources/settings/privacy_page/.
  * @constructor
  * @extends {CrSettingsBrowserTest}
 */
 function CrSettingsPrivacyPageTest() {}
 
 CrSettingsPrivacyPageTest.prototype = {
   __proto__: CrSettingsBrowserTest.prototype,
 
   /** @override */
   browsePreload: 'chrome://md-settings/privacy_page/privacy_page.html',
 
   /** @override */
-  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
     ROOT_PATH + 'ui/webui/resources/js/promise_resolver.js',
     'test_browser_proxy.js',
     'privacy_page_test.js',
   ]),
 };
 
 TEST_F('CrSettingsPrivacyPageTest', 'PrivacyPage', function() {
   settings_privacy_page.registerTests();
   mocha.run();
 });
 
 /**
  * Test fixture for chrome/browser/resources/settings/site_settings/.
  * @constructor
  * @extends {CrSettingsBrowserTest}
 */
 function CrSettingsSiteSettingsTest() {}
 
 CrSettingsSiteSettingsTest.prototype = {
   __proto__: CrSettingsBrowserTest.prototype,
 
   /** @override */
   browsePreload: 'chrome://md-settings/prefs/prefs.html',
 
   /** @override */
-  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
     'site_details_tests.js',
     'site_details_permission_tests.js',
     'site_list_tests.js',
     'site_settings_category_tests.js',
     'test_browser_proxy.js',
     'test_site_settings_prefs_browser_proxy.js',
   ]),
 };
 
 TEST_F('CrSettingsSiteSettingsTest', 'SiteSettings', function() {
@@ skipping 13 matching lines @@
 */
 function CrSettingsDevicePageTest() {}
 
 CrSettingsDevicePageTest.prototype = {
   __proto__: CrSettingsBrowserTest.prototype,
 
   /** @override */
   browsePreload: 'chrome://md-settings/device_page/device_page.html',
 
   /** @override */
-  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
     ROOT_PATH + 'ui/webui/resources/js/assert.js',
     '../fake_chrome_event.js',
     'fake_settings_private.js',
     'fake_system_display.js',
     'device_page_tests.js',
   ]),
 };
 
 TEST_F('CrSettingsDevicePageTest', 'DisplayTest', function() {
   mocha.grep(assert(device_page_tests.TestNames.Display)).run();
@@ skipping 15 matching lines @@
 */
 function CrSettingsMenuTest() {}
 
 CrSettingsMenuTest.prototype = {
   __proto__: CrSettingsBrowserTest.prototype,
 
   /** @override */
   browsePreload: 'chrome://md-settings/settings_menu/settings_menu.html',
 
   /** @override */
-  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
     'settings_menu_test.js',
   ]),
 };
 
 TEST_F('CrSettingsMenuTest', 'SettingsMenu', function() {
   settings_menu.registerTests();
   mocha.run();
 });
 
 GEN('#if !defined(OS_CHROMEOS)');
@@ skipping 49 matching lines @@
 function CrSettingsLanguagesPageTest() {}
 
 CrSettingsLanguagesPageTest.prototype = {
   __proto__: CrSettingsBrowserTest.prototype,
 
   /** @override */
   browsePreload: 'chrome://md-settings/languages_page/languages_page.html',
 
   /** @override */
   extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
+    '../fake_chrome_event.js',
     'fake_language_settings_private.js',
     'fake_settings_private.js',
     'languages_page_tests.js',
   ]),
 };
 
 TEST_F('CrSettingsLanguagesPageTest', 'LanguagesPage', function() {
   mocha.run();
 });
 
 function CrSettingsRadioGroupTest() {}
 
 CrSettingsRadioGroupTest.prototype = {
   __proto__: CrSettingsBrowserTest.prototype,
 
   /** @override */
   browsePreload: 'chrome://md-settings/controls/settings_radio_group.html',
 
   /** @override */
-  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+  extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
     'radio_group_tests.js',
   ]),
 };
 
 TEST_F('CrSettingsRadioGroupTest', 'All', function() {
   mocha.run();
 });