Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2050043004: Increase the number of pthread keys available to the IRT (Closed)

Created:
4 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 6 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Increase the number of pthread keys available to the IRT The Mojo EDK uses an additional key for thread-local storage and is now necessary to bring up IPC in Chrome. This is apparently enough to push us over the 16 key limit in some cases. Doubling to 32 to leave some room for further expansion. BUG=https://code.google.com/p/chromium/issues/detail?id=612500 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/33ea6a02332d0944150e9445a584d6f26718509b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/untrusted/irt/irt_private_pthread.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Ken Rockot(use gerrit already)
Woops, never sent this out. Please see https://codereview.chromium.org/2033243003 for context. Thanks!
4 years, 6 months ago (2016-06-10 20:24:52 UTC) #3
Mark Seaborn
If you use "BUG=NNNN" in a NaCl change, Bugdroid won't update the right issue tracker. ...
4 years, 6 months ago (2016-06-13 19:25:12 UTC) #4
Ken Rockot(use gerrit already)
On 2016/06/13 at 19:25:12, mseaborn wrote: > If you use "BUG=NNNN" in a NaCl change, ...
4 years, 6 months ago (2016-06-13 19:37:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050043004/1
4 years, 6 months ago (2016-06-13 19:38:00 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 20:33:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/33ea6a023...

Powered by Google App Engine
This is Rietveld 408576698