third_party/WebKit/Source/core/html/track/TrackBase.h - Issue 2050043002: Generate and assign media track ids in demuxers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/TrackBase.h

Issue 2050043002: Generate and assign media track ids in demuxers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use-streamparser-trackid

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/Source/core/html/track/TrackBase.cpp » ('j') | third_party/WebKit/public/platform/WebSourceBufferClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/TrackBase.h

diff --git a/third_party/WebKit/Source/core/html/track/TrackBase.h b/third_party/WebKit/Source/core/html/track/TrackBase.h

index d622095798c74391032891f391871ecade7e6268..238b6782554520cbf21d7022de2c92e35c49ba9e 100644

--- a/third_party/WebKit/Source/core/html/track/TrackBase.h

+++ b/third_party/WebKit/Source/core/html/track/TrackBase.h

@@ -40,7 +40,7 @@ class CORE_EXPORT TrackBase : public Supplementable<TrackBase> {

public:

virtual ~TrackBase();

- WebMediaPlayer::TrackId trackId() const { return m_trackId; }

+ WebMediaPlayer::TrackId trackId() const { return m_id; }

chcunningham 2016/06/13 19:30:43 Why do we have both this and id() methods? Can you

servolk 2016/06/13 22:00:16 Done.

WebMediaPlayer::TrackType type() const { return m_type; }

@@ -58,7 +58,6 @@ public:

protected:

TrackBase(WebMediaPlayer::TrackType, const AtomicString& kind, const AtomicString& label, const AtomicString& language, const String& id);

- WebMediaPlayer::TrackId m_trackId;

WebMediaPlayer::TrackType m_type;

AtomicString m_kind;

AtomicString m_label;