third_party/WebKit/Source/core/html/track/TextTrackList.cpp - Issue 2050043002: Generate and assign media track ids in demuxers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/TextTrackList.cpp

Issue 2050043002: Generate and assign media track ids in demuxers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use-streamparser-trackid

Patch Set: rebase to ToT Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/track/AudioTrack.cpp ('k') | third_party/WebKit/Source/core/html/track/TrackBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/TextTrackList.cpp

diff --git a/third_party/WebKit/Source/core/html/track/TextTrackList.cpp b/third_party/WebKit/Source/core/html/track/TextTrackList.cpp

index c7ac3c10ff58da7f241ba9dd00a51a1019c07943..02dc1e260d9b9b56c429aa193642b1ef3a84075b 100644

--- a/third_party/WebKit/Source/core/html/track/TextTrackList.cpp

+++ b/third_party/WebKit/Source/core/html/track/TextTrackList.cpp

@@ -134,7 +134,7 @@ TextTrack* TextTrackList::getTrackById(const AtomicString& id)

// to the value of the id argument.

for (unsigned i = 0; i < length(); ++i) {

TextTrack* track = anonymousIndexedGetter(i);

- if (track->id() == id)

+ if (String(track->id()) == id)

return track;

}

« no previous file with comments | « third_party/WebKit/Source/core/html/track/AudioTrack.cpp ('k') | third_party/WebKit/Source/core/html/track/TrackBase.h » ('j') | no next file with comments »