media/blink/websourcebuffer_impl.cc - Issue 2050043002: Generate and assign media track ids in demuxers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/websourcebuffer_impl.cc

Issue 2050043002: Generate and assign media track ids in demuxers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use-streamparser-trackid

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/blink/websourcebuffer_impl.cc

diff --git a/media/blink/websourcebuffer_impl.cc b/media/blink/websourcebuffer_impl.cc

index d53cb7ed436e5d88ff4082e1eb5317530898aa2d..8c5e77addc096ea5bf3618988d8b360d86e96e24 100644

--- a/media/blink/websourcebuffer_impl.cc

+++ b/media/blink/websourcebuffer_impl.cc

@@ -183,8 +183,7 @@ void WebSourceBufferImpl::InitSegmentReceived(

for (const auto& track : tracks->tracks()) {

blink::WebSourceBufferClient::MediaTrackInfo trackInfo;

trackInfo.trackType = mediaTrackTypeToBlink(track->type());

- trackInfo.byteStreamTrackId = blink::WebString::fromUTF8(

- base::UintToString(track->byteStreamTrackId()));

+ trackInfo.byteStreamTrackId = blink::WebString::fromUTF8(track->id());

chcunningham 2016/06/09 17:57:19 I think you this is not the bytestreamTrackId - yo

servolk 2016/06/09 19:14:46 Done.

trackInfo.kind = blink::WebString::fromUTF8(track->kind());

trackInfo.label = blink::WebString::fromUTF8(track->label());

trackInfo.language = blink::WebString::fromUTF8(track->language());

« media/base/media_tracks.cc ('K') | « media/blink/webmediaplayer_impl_unittest.cc ('k') | media/filters/chunk_demuxer.h » ('j') | media/filters/ffmpeg_demuxer.cc » ('J')