Generate and assign media track ids in demuxers.

media/base/media_tracks.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_MEDIA_TRACKS_H_
 #define MEDIA_BASE_MEDIA_TRACKS_H_
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 10 matching lines @@
 
 class MEDIA_EXPORT MediaTracks {
  public:
   using MediaTracksCollection = std::vector<std::unique_ptr<MediaTrack>>;
 
   MediaTracks();
   ~MediaTracks();
 
   // Adds a new audio track. The |bytestreamTrackId| must uniquely identify the
   // track within the bytestream.
-  void AddAudioTrack(const AudioDecoderConfig& config,
-                     StreamParser::TrackId bytestream_track_id,
-                     const std::string& kind,
-                     const std::string& label,
-                     const std::string& language);
+  MediaTrack* AddAudioTrack(const AudioDecoderConfig& config,
+                            StreamParser::TrackId bytestream_track_id,
+                            const std::string& kind,
+                            const std::string& label,
+                            const std::string& language);
   // Adds a new video track. The |bytestreamTrackId| must uniquely identify the
   // track within the bytestream.
-  void AddVideoTrack(const VideoDecoderConfig& config,
-                     StreamParser::TrackId bytestream_track_id,
-                     const std::string& kind,
-                     const std::string& label,
-                     const std::string& language);
+  MediaTrack* AddVideoTrack(const VideoDecoderConfig& config,
+                            StreamParser::TrackId bytestream_track_id,
+                            const std::string& kind,
+                            const std::string& label,
+                            const std::string& language);
 
   const MediaTracksCollection& tracks() const { return tracks_; }
 
   const AudioDecoderConfig& getAudioConfig(
       StreamParser::TrackId bytestream_track_id) const;
   const VideoDecoderConfig& getVideoConfig(
       StreamParser::TrackId bytestream_track_id) const;
 
   // TODO(servolk): These are temporary helpers useful until all code paths are
   // converted to properly handle multiple media tracks.
   const AudioDecoderConfig& getFirstAudioConfig() const;

[xhwang, 2016/06/10 17:06:54]

nit: s/get/Get

[servolk, 2016/06/10 22:05:25]

Acknowledged.

   const VideoDecoderConfig& getFirstVideoConfig() const;

[xhwang, 2016/06/10 17:06:54]

Actually do we still need these two functions? Seems like they are not used now.

[servolk, 2016/06/10 22:05:25]

These are still used in a couple of unit tests. I have a separate CL to remove
these: https://codereview.chromium.org/1833053005/

 
  private:
   MediaTracksCollection tracks_;
   std::map<StreamParser::TrackId, AudioDecoderConfig> audio_configs_;
   std::map<StreamParser::TrackId, VideoDecoderConfig> video_configs_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaTracks);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_MEDIA_TRACKS_H_