[Media Router WebUI] Remove flex layout from cast button

[Media Router WebUI] Remove flex layout from cast button

The cast button in the route details view should not fill the remaining
horizontal space it has, so this change removes the flex property from
it.

BUG=618508
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b4a9571b30800a635327ab6fe40eb8014901f8e0
Cr-Commit-Position: refs/heads/master@{#399003}

[btolsch, 2016-06-09 00:30:39]

Description was changed from

==========
[Media Router WebUI] Remove flex layout from cast button

The cast button in the route details view should not fill the remaining
horizontal space it has, so this change removes the flex property from
it.

BUG=618508
==========

to

==========
[Media Router WebUI] Remove flex layout from cast button

The cast button in the route details view should not fill the remaining
horizontal space it has, so this change removes the flex property from
it.

BUG=618508
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[btolsch, 2016-06-09 01:01:01]

btolsch@chromium.org changed reviewers:
+ apacible@chromium.org

[btolsch, 2016-06-09 01:01:01]

This has actually always made the button wide, but it seems like it's only
noticeable now because the text alignment has changed.  If the intention is to
have it be wide, we could fix the alignment instead.  PTAL, thanks!

[apacible, 2016-06-09 05:17:27]

Can you add before/after screenshots (LTR/RTL)? Thanks!

[btolsch, 2016-06-09 06:36:56]

Sure! I tried searching for a bit but can't figure out if I can get RTL in
English.  Is there a way to do that?  I used Hebrew again so you'll have to
trust the buttons are in the right order :P.  I can redo them if I can get RTL
in English to work.

Original LTR:
https://screenshot.googleplex.com/8Ln5VVKLoDV
Original RTL:
https://screenshot.googleplex.com/OYwm7hB1daS

New LTR:
https://screenshot.googleplex.com/MF6GSMeiaCZ
New RTL:
https://screenshot.googleplex.com/p8A6K7Bm8bd

[apacible, 2016-06-09 15:58:14]

LGTM; this is fine. :)

[amp, 2016-06-09 16:19:55]

On 2016/06/09 06:36:56, btolsch wrote:
> Sure! I tried searching for a bit but can't figure out if I can get RTL in
> English.  Is there a way to do that?  I used Hebrew again so you'll have to
> trust the buttons are in the right order :P.  I can redo them if I can get RTL
> in English to work.
> 
> Original LTR:
> https://screenshot.googleplex.com/8Ln5VVKLoDV
> Original RTL:
> https://screenshot.googleplex.com/OYwm7hB1daS
> 
> New LTR:
> https://screenshot.googleplex.com/MF6GSMeiaCZ
> New RTL:
> https://screenshot.googleplex.com/p8A6K7Bm8bd

Can you show some screenshots with an email address in there as well?  I seem to
recall there were issues with the email not showing up correctly (but I may be
confusing this with sink names and domains).

[btolsch, 2016-06-09 17:42:35]

I'm not sure what issue you're referring to Adam, but here's some screenshots.

Original w/ email:
https://screenshot.googleplex.com/W52MJEPhPM2

New w/ email:
https://screenshot.googleplex.com/QJq7WbQH86z

[amp, 2016-06-09 19:51:21]

On 2016/06/09 17:42:35, btolsch wrote:
> I'm not sure what issue you're referring to Adam, but here's some screenshots.
> 
> Original w/ email:
> https://screenshot.googleplex.com/W52MJEPhPM2
> 
> New w/ email:
> https://screenshot.googleplex.com/QJq7WbQH86z

It was probably unrelated.  At any rate thanks for checking the email as well.

[btolsch, 2016-06-09 20:03:52]

The CQ bit was checked by btolsch@chromium.org

[commit-bot: I haz the power, 2016-06-09 20:04:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2049953003/1

[commit-bot: I haz the power, 2016-06-09 20:47:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-09 20:47:13]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-09 20:49:05]

Description was changed from

==========
[Media Router WebUI] Remove flex layout from cast button

The cast button in the route details view should not fill the remaining
horizontal space it has, so this change removes the flex property from
it.

BUG=618508
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[Media Router WebUI] Remove flex layout from cast button

The cast button in the route details view should not fill the remaining
horizontal space it has, so this change removes the flex property from
it.

BUG=618508
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b4a9571b30800a635327ab6fe40eb8014901f8e0
Cr-Commit-Position: refs/heads/master@{#399003}
==========

[commit-bot: I haz the power, 2016-06-09 20:49:06]

Patchset 1 (id:??) landed as
https://crrev.com/b4a9571b30800a635327ab6fe40eb8014901f8e0
Cr-Commit-Position: refs/heads/master@{#399003}