Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3898)

Unified Diff: chrome/test/data/webui/settings/cr_settings_browsertest.js

Issue 2049943003: MD Settings: split browser tests into smaller chunks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: asdf Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/cr_settings_browsertest.js
diff --git a/chrome/test/data/webui/settings/cr_settings_browsertest.js b/chrome/test/data/webui/settings/cr_settings_browsertest.js
index 6a2d1dc782ed11fad59ddc00707095c0fd9fa110..ce78242536fdef8618ad304b8c27aab517798b8d 100644
--- a/chrome/test/data/webui/settings/cr_settings_browsertest.js
+++ b/chrome/test/data/webui/settings/cr_settings_browsertest.js
@@ -54,21 +54,23 @@ CrSettingsBrowserTest.prototype = {
// Have to include command_line.h manually due to GEN calls below.
GEN('#include "base/command_line.h"');
-// Times out on memory bots. http://crbug.com/534718
-GEN('#if defined(MEMORY_SANITIZER)');
-GEN('#define MAYBE_CrSettingsTest DISABLED_CrSettingsTest');
-GEN('#else');
-GEN('#define MAYBE_CrSettingsTest CrSettingsTest');
-GEN('#endif');
-
-// TODO(dbeam): these should be split into multiple TEST_F()s.
-TEST_F('CrSettingsBrowserTest', 'MAYBE_CrSettingsTest', function() {
+TEST_F('CrSettingsBrowserTest', 'Checkbox', function() {
settings_checkbox.registerTests();
+ mocha.run();
+});
+
+TEST_F('CrSettingsBrowserTest', 'DropdownMenu', function() {
settings_dropdown_menu.registerTests();
+ mocha.run();
+});
+
+TEST_F('CrSettingsBrowserTest', 'PrefUtil', function() {
settings_prefUtil.registerTests();
- settings_prefs.registerTests();
+ mocha.run();
+});
- // Run all registered tests.
+TEST_F('CrSettingsBrowserTest', 'Prefs', function() {
+ settings_prefs.registerTests();
mocha.run();
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698