Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/profiler/tick-sample.h

Issue 2049903002: Revert of Move stack trace extraction code out of TickSample::Init (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/profiler/profile-generator.cc ('k') | src/profiler/tick-sample.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_PROFILER_TICK_SAMPLE_H_ 5 #ifndef V8_PROFILER_TICK_SAMPLE_H_
6 #define V8_PROFILER_TICK_SAMPLE_H_ 6 #define V8_PROFILER_TICK_SAMPLE_H_
7 7
8 #include "include/v8.h" 8 #include "include/v8.h"
9 9
10 #include "src/base/platform/time.h" 10 #include "src/base/platform/time.h"
(...skipping 18 matching lines...) Expand all
29 // include the runtime function we're calling. Externally exposed tick 29 // include the runtime function we're calling. Externally exposed tick
30 // samples don't care. 30 // samples don't care.
31 enum RecordCEntryFrame { kIncludeCEntryFrame, kSkipCEntryFrame }; 31 enum RecordCEntryFrame { kIncludeCEntryFrame, kSkipCEntryFrame };
32 32
33 TickSample() 33 TickSample()
34 : state(OTHER), 34 : state(OTHER),
35 pc(NULL), 35 pc(NULL),
36 external_callback_entry(NULL), 36 external_callback_entry(NULL),
37 frames_count(0), 37 frames_count(0),
38 has_external_callback(false), 38 has_external_callback(false),
39 update_stats(true) {} 39 update_stats(true),
40 top_frame_type(StackFrame::NONE) {}
40 void Init(Isolate* isolate, const v8::RegisterState& state, 41 void Init(Isolate* isolate, const v8::RegisterState& state,
41 RecordCEntryFrame record_c_entry_frame, bool update_stats); 42 RecordCEntryFrame record_c_entry_frame, bool update_stats);
42 static bool GetStackSample(Isolate* isolate, const v8::RegisterState& state, 43 static void GetStackSample(Isolate* isolate, const v8::RegisterState& state,
43 RecordCEntryFrame record_c_entry_frame, 44 RecordCEntryFrame record_c_entry_frame,
44 void** frames, size_t frames_limit, 45 void** frames, size_t frames_limit,
45 v8::SampleInfo* sample_info); 46 v8::SampleInfo* sample_info);
46 StateTag state; // The state of the VM. 47 StateTag state; // The state of the VM.
47 Address pc; // Instruction pointer. 48 Address pc; // Instruction pointer.
48 union { 49 union {
49 Address tos; // Top stack value (*sp). 50 Address tos; // Top stack value (*sp).
50 Address external_callback_entry; 51 Address external_callback_entry;
51 }; 52 };
52 static const unsigned kMaxFramesCountLog2 = 8; 53 static const unsigned kMaxFramesCountLog2 = 8;
53 static const unsigned kMaxFramesCount = (1 << kMaxFramesCountLog2) - 1; 54 static const unsigned kMaxFramesCount = (1 << kMaxFramesCountLog2) - 1;
54 Address stack[kMaxFramesCount]; // Call stack. 55 Address stack[kMaxFramesCount]; // Call stack.
55 base::TimeTicks timestamp; 56 base::TimeTicks timestamp;
56 unsigned frames_count : kMaxFramesCountLog2; // Number of captured frames. 57 unsigned frames_count : kMaxFramesCountLog2; // Number of captured frames.
57 bool has_external_callback : 1; 58 bool has_external_callback : 1;
58 bool update_stats : 1; // Whether the sample should update aggregated stats. 59 bool update_stats : 1; // Whether the sample should update aggregated stats.
60 StackFrame::Type top_frame_type : 5;
59 }; 61 };
60 62
61 63
62 #if defined(USE_SIMULATOR) 64 #if defined(USE_SIMULATOR)
63 class SimulatorHelper { 65 class SimulatorHelper {
64 public: 66 public:
65 // Returns true if register values were successfully retrieved 67 // Returns true if register values were successfully retrieved
66 // from the simulator, otherwise returns false. 68 // from the simulator, otherwise returns false.
67 static bool FillRegisters(Isolate* isolate, v8::RegisterState* state); 69 static bool FillRegisters(Isolate* isolate, v8::RegisterState* state);
68 }; 70 };
69 #endif // USE_SIMULATOR 71 #endif // USE_SIMULATOR
70 72
71 } // namespace internal 73 } // namespace internal
72 } // namespace v8 74 } // namespace v8
73 75
74 #endif // V8_PROFILER_TICK_SAMPLE_H_ 76 #endif // V8_PROFILER_TICK_SAMPLE_H_
OLDNEW
« no previous file with comments | « src/profiler/profile-generator.cc ('k') | src/profiler/tick-sample.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698