Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2049903002: Revert of Move stack trace extraction code out of TickSample::Init (Closed)

Created:
4 years, 6 months ago by alph
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Move stack trace extraction code out of TickSample::Init (patchset #1 id:1 of https://codereview.chromium.org/2007343003/ ) Reason for revert: Make MSAN arm bot flaky Original issue's description: > Move stack trace extraction code out of TickSample::Init > > Make it a part of V8 API GetStackSample function. > Also expose external_callback_entry in SampleInfo to break dependency > of clients on internal V8 structures. > > BUG=v8:4789 > > Committed: https://crrev.com/70acfe39c07322144f5fe9b40bb584a8b1099ffd > Cr-Commit-Position: refs/heads/master@{#36831} TBR=yangguo@chromium.org,lpy@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4789 Committed: https://crrev.com/9ac4a6efa9a732be2c1c2cb729bc992a2322520a Cr-Commit-Position: refs/heads/master@{#36835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -59 lines) Patch
M include/v8.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/profiler/profile-generator.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M src/profiler/tick-sample.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/profiler/tick-sample.cc View 5 chunks +55 lines, -48 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
alph
Created Revert of Move stack trace extraction code out of TickSample::Init
4 years, 6 months ago (2016-06-08 19:47:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049903002/1
4 years, 6 months ago (2016-06-08 19:47:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 19:47:36 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 19:48:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ac4a6efa9a732be2c1c2cb729bc992a2322520a
Cr-Commit-Position: refs/heads/master@{#36835}

Powered by Google App Engine
This is Rietveld 408576698