Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Unified Diff: content/public/android/java/src/org/chromium/content/app/DownloadProcessService.java

Issue 2049843004: Upstream: Renderers are running in WebAPKs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/app/DownloadProcessService.java
diff --git a/content/public/android/java/src/org/chromium/content/app/DownloadProcessService.java b/content/public/android/java/src/org/chromium/content/app/DownloadProcessService.java
index 7ea954bdd734fab3808ecfd1d4903ea3bab5bb40..b95de2e06ff66aff98b5883b8075f07a7340d11a 100644
--- a/content/public/android/java/src/org/chromium/content/app/DownloadProcessService.java
+++ b/content/public/android/java/src/org/chromium/content/app/DownloadProcessService.java
@@ -40,12 +40,13 @@ public class DownloadProcessService extends ChildProcessService {
@SuppressLint("NewApi")
public int onStartCommand(Intent intent, int flags, int startId) {
assert Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR2;
- initializeParams(intent);
+ ChildProcessServiceImpl impl = getChildProcessServiceImpl();
Maria 2016/06/17 17:09:24 I think that instead of surfacing the impl and let
Xi Han 2016/06/17 18:35:20 That is what I did before. Sorry Peter, revert it
+ impl.initializeParams(intent);
Bundle bundle = intent.getExtras();
if (bundle != null) {
IBinder binder = bundle.getBinder(ChildProcessConstants.EXTRA_CHILD_PROCESS_CALLBACK);
mCallback = IChildProcessCallback.Stub.asInterface(binder);
- getServiceInfo(bundle);
+ impl.getServiceInfo(bundle);
}
return START_STICKY;
}

Powered by Google App Engine
This is Rietveld 408576698