Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2049833002: Enable on stack reload in standalone embedder (Closed)

Created:
4 years, 6 months ago by Cutch
Modified:
4 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable on stack reload in standalone embedder - [x] Implement Isolate::OnStackReload - [x] Now that we don't invoke Dart code during loading, stop blocking class finalization during loading BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/4d5ad08d113b1ea6e12382bcf0f48538008b8a3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M runtime/vm/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate_reload.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M runtime/vm/object_reload.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 6 months ago (2016-06-08 17:58:32 UTC) #3
rmacnak
lgtm
4 years, 6 months ago (2016-06-08 17:59:35 UTC) #4
Cutch
4 years, 6 months ago (2016-06-08 18:00:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d5ad08d113b1ea6e12382bcf0f48538008b8a3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698