Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 204983019: Remove style attribute from SVGElement.idl (Closed)

Created:
6 years, 9 months ago by rwlbuis
Modified:
6 years, 9 months ago
Reviewers:
pdr.
CC:
blink-reviews, krit, arv+blink, fs, watchdog-blink-watchlist_google.com, ed+blinkwatch_opera.com, f(malita), Inactive, gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove style attribute from SVGElement.idl This attribute is already present on Element.idl. This change avoids extra bindings code being written. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/svg/SVGElement.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 25 (0 generated)
rwlbuis
PTAL. A pity the try-bots are flaky :/
6 years, 9 months ago (2014-03-24 19:01:50 UTC) #1
pdr.
On 2014/03/24 19:01:50, rwlbuis wrote: > PTAL. A pity the try-bots are flaky :/ LGTM ...
6 years, 9 months ago (2014-03-24 19:07:21 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-24 19:07:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/204983019/1
6 years, 9 months ago (2014-03-24 19:07:25 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 19:09:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-24 19:09:58 UTC) #6
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-24 19:11:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/204983019/1
6 years, 9 months ago (2014-03-24 19:11:47 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 19:35:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-24 19:35:01 UTC) #10
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-24 20:02:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/204983019/1
6 years, 9 months ago (2014-03-24 20:02:15 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 20:04:37 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-24 20:04:38 UTC) #14
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-24 20:12:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/204983019/1
6 years, 9 months ago (2014-03-24 20:12:36 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 20:51:54 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-24 20:51:55 UTC) #18
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-24 21:00:28 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/204983019/1
6 years, 9 months ago (2014-03-24 21:00:32 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 21:53:17 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-24 21:53:18 UTC) #22
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-24 21:56:43 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/204983019/1
6 years, 9 months ago (2014-03-24 21:56:55 UTC) #24
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 23:51:10 UTC) #25
Message was sent while issue was closed.
Change committed as 169887

Powered by Google App Engine
This is Rietveld 408576698