Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 204983016: Update expectations for Ubuntu12-GTX660 (Closed)

Created:
6 years, 9 months ago by borenet
Modified:
6 years, 9 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Update expectations for Ubuntu12-GTX660 Move ATI5770 expectations to GTX660 BUG=skia:2325 NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13910

Patch Set 1 #

Total comments: 3

Patch Set 2 : retry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17696 lines, -60165 lines) Patch
D expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Debug/expected-results.json View 1 1 chunk +0 lines, -11485 lines 0 comments Download
D expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Release/expected-results.json View 1 1 chunk +0 lines, -11479 lines 0 comments Download
D expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Debug/expected-results.json View 1 1 chunk +0 lines, -11485 lines 0 comments Download
D expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release/expected-results.json View 1 1 chunk +0 lines, -11485 lines 0 comments Download
A + expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json View 1 1103 chunks +4463 lines, -3623 lines 0 comments Download
A + expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json View 1 1116 chunks +4467 lines, -3624 lines 0 comments Download
A + expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 1 1179 chunks +4369 lines, -3490 lines 0 comments Download
A + expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/expected-results.json View 1 1174 chunks +4397 lines, -3494 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
borenet
https://codereview.chromium.org/204983016/diff/1/expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json File expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json (right): https://codereview.chromium.org/204983016/diff/1/expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json#newcode1 expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json:1: { These were copied from the ATI5770 expectations and ...
6 years, 9 months ago (2014-03-24 15:39:20 UTC) #1
epoger
lgtm https://codereview.chromium.org/204983016/diff/1/expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json File expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json (right): https://codereview.chromium.org/204983016/diff/1/expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json#newcode7 expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json:7: }, On 2014/03/24 15:39:21, borenet wrote: > Is ...
6 years, 9 months ago (2014-03-24 15:55:44 UTC) #2
borenet
The CQ bit was checked by borenet@google.com
6 years, 9 months ago (2014-03-24 16:01:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/204983016/1
6 years, 9 months ago (2014-03-24 16:01:47 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 16:11:12 UTC) #5
commit-bot: I haz the power
Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
6 years, 9 months ago (2014-03-24 16:11:12 UTC) #6
epoger
On 2014/03/24 16:11:12, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 9 months ago (2014-03-24 16:15:32 UTC) #7
borenet
The CQ bit was checked by borenet@google.com
6 years, 9 months ago (2014-03-24 16:58:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/204983016/10001
6 years, 9 months ago (2014-03-24 16:58:29 UTC) #9
commit-bot: I haz the power
Change committed as 13910
6 years, 9 months ago (2014-03-24 16:59:29 UTC) #10
mtklein
On 2014/03/24 16:59:29, I haz the power (commit-bot) wrote: > Change committed as 13910 The ...
6 years, 9 months ago (2014-03-24 22:38:34 UTC) #11
borenet
6 years, 9 months ago (2014-03-25 12:24:52 UTC) #12
Message was sent while issue was closed.
On 2014/03/24 22:38:34, mtklein wrote:
> On 2014/03/24 16:59:29, I haz the power (commit-bot) wrote:
> > Change committed as 13910
> 
> The GTX660 bots were all green before this CL and are now failing in GM
compare.
>  Is this intended?  Seems like the opposite of intended?
> 
> Is it, we're going here from Missing to Wrong, to be rebaselined into Right
> later?

Yeah, there weren't any expectations before.  There are ~100 GMs failing
comparison per bot.  I'm desperately hoping all of them aren't flaky.

Powered by Google App Engine
This is Rietveld 408576698