Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 204983012: Stop using net::FileStream synchronously in third_party/zlib (Closed)

Created:
6 years, 9 months ago by hashimoto
Modified:
6 years, 9 months ago
Reviewers:
satorux1
CC:
chromium-reviews
Visibility:
Public.

Description

Stop using net::FileStream synchronously in third_party/zlib Use base::File instead BUG=351823 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
D third_party/zlib/google/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/zlib/google/zip.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M third_party/zlib/google/zip_reader.cc View 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
6 years, 9 months ago (2014-03-24 05:32:57 UTC) #1
satorux1
lgtm
6 years, 9 months ago (2014-03-24 05:44:40 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 9 months ago (2014-03-24 05:57:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/204983012/1
6 years, 9 months ago (2014-03-24 05:57:05 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 09:32:17 UTC) #5
Message was sent while issue was closed.
Change committed as 258897

Powered by Google App Engine
This is Rietveld 408576698