Deprecate the unused AutoCleanupSettigsProto.clean_up_strategy policy.

The underlying implementation has been removed from Chrome OS.

https://chromium-review.googlesource.com/#/c/190984/
https://chromium-review.googlesource.com/#/c/191137/

BUG=343781
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266939

[bartfab (slow), 2014-03-27 14:18:37]

lgtm

https://codereview.chromium.org/204983009/diff/1/components/policy/resources/...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/204983009/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:3663: 'supported_on':
['chrome_os:32-'],
Nit: s/32-/32-34/

https://codereview.chromium.org/204983009/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:3673: 'desc': '''Controls the
automatic clean-up behavior on <ph name="PRODUCT_OS_NAME">$2<ex>Google Chrome
OS</ex></ph> devices. Automatic clean-up is triggered when the amount of free
disk space reaches a critical level to recover some disk space.
Nit: Please add a sentence at the top of |desc| that says something like:

This policy is deprecated. <ph name="PRODUCT_OS_NAME">$2<ex>Google Chrome
OS</ex></ph> will always use the 'RemoveLRU' clean-up strategy.

[David Roche, 2014-04-18 21:36:28]

The CQ bit was checked by davidroche@chromium.org

[commit-bot: I haz the power, 2014-04-18 21:37:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davidroche@chromium.org/204983009/20001

[commit-bot: I haz the power, 2014-04-18 22:06:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-18 22:06:34]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_gn_rel

[David Roche, 2014-04-18 22:31:57]

Daniel, can I get your OWNERS approval for this?

https://codereview.chromium.org/204983009/diff/1/components/policy/resources/...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/204983009/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:3663: 'supported_on':
['chrome_os:32-'],
On 2014/03/27 14:18:38, bartfab wrote:
> Nit: s/32-/32-34/

Done.

https://codereview.chromium.org/204983009/diff/1/components/policy/resources/...
components/policy/resources/policy_templates.json:3673: 'desc': '''Controls the
automatic clean-up behavior on <ph name="PRODUCT_OS_NAME">$2<ex>Google Chrome
OS</ex></ph> devices. Automatic clean-up is triggered when the amount of free
disk space reaches a critical level to recover some disk space.
On 2014/03/27 14:18:38, bartfab wrote:
> Nit: Please add a sentence at the top of |desc| that says something like:
> 
> This policy is deprecated. <ph name="PRODUCT_OS_NAME">$2<ex>Google Chrome
> OS</ex></ph> will always use the 'RemoveLRU' clean-up strategy.

Done.

[dconnelly, 2014-04-22 10:04:15]

On 2014/04/18 22:31:57, David Roche wrote:
> Daniel, can I get your OWNERS approval for this?
> 
>
https://codereview.chromium.org/204983009/diff/1/components/policy/resources/...
> File components/policy/resources/policy_templates.json (right):
> 
>
https://codereview.chromium.org/204983009/diff/1/components/policy/resources/...
> components/policy/resources/policy_templates.json:3663: 'supported_on':
> ['chrome_os:32-'],
> On 2014/03/27 14:18:38, bartfab wrote:
> > Nit: s/32-/32-34/
> 
> Done.
> 
>
https://codereview.chromium.org/204983009/diff/1/components/policy/resources/...
> components/policy/resources/policy_templates.json:3673: 'desc': '''Controls
the
> automatic clean-up behavior on <ph name="PRODUCT_OS_NAME">$2<ex>Google Chrome
> OS</ex></ph> devices. Automatic clean-up is triggered when the amount of free
> disk space reaches a critical level to recover some disk space.
> On 2014/03/27 14:18:38, bartfab wrote:
> > Nit: Please add a sentence at the top of |desc| that says something like:
> > 
> > This policy is deprecated. <ph name="PRODUCT_OS_NAME">$2<ex>Google Chrome
> > OS</ex></ph> will always use the 'RemoveLRU' clean-up strategy.
> 
> Done.

Is the underlying functionality gone? Policies are usually deprecated for a
release before removing the corresponding policy handling logic, but if the
functionality itself is gone there's no point.

[David Roche, 2014-04-22 15:14:18]

On 2014/04/22 10:04:15, dconnelly wrote:
> On 2014/04/18 22:31:57, David Roche wrote:
> > Daniel, can I get your OWNERS approval for this?
> > 
> >
>
https://codereview.chromium.org/204983009/diff/1/components/policy/resources/...
> > File components/policy/resources/policy_templates.json (right):
> > 
> >
>
https://codereview.chromium.org/204983009/diff/1/components/policy/resources/...
> > components/policy/resources/policy_templates.json:3663: 'supported_on':
> > ['chrome_os:32-'],
> > On 2014/03/27 14:18:38, bartfab wrote:
> > > Nit: s/32-/32-34/
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/204983009/diff/1/components/policy/resources/...
> > components/policy/resources/policy_templates.json:3673: 'desc': '''Controls
> the
> > automatic clean-up behavior on <ph name="PRODUCT_OS_NAME">$2<ex>Google
Chrome
> > OS</ex></ph> devices. Automatic clean-up is triggered when the amount of
free
> > disk space reaches a critical level to recover some disk space.
> > On 2014/03/27 14:18:38, bartfab wrote:
> > > Nit: Please add a sentence at the top of |desc| that says something like:
> > > 
> > > This policy is deprecated. <ph name="PRODUCT_OS_NAME">$2<ex>Google Chrome
> > > OS</ex></ph> will always use the 'RemoveLRU' clean-up strategy.
> > 
> > Done.
> 
> Is the underlying functionality gone? Policies are usually deprecated for a
> release before removing the corresponding policy handling logic, but if the
> functionality itself is gone there's no point.

The underlying functionality was removed in these 2 CLs, submitted Apr 1 and 3:
https://chromium-review.googlesource.com/#/c/190984/
https://chromium-review.googlesource.com/#/c/191137/

Sorry for not making that clear; I'll update the description on this review.

[dconnelly, 2014-04-22 15:17:36]

lgtm

[Joao da Silva, 2014-04-22 15:18:52]

Drive-by comment.

https://codereview.chromium.org/204983009/diff/40001/components/policy/resour...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/204983009/diff/40001/components/policy/resour...
components/policy/resources/policy_templates.json:3663: 'supported_on':
['chrome_os:32-34'],
35 has already branched and includes this policy. Was the support removed on
that branch? If not then this needs to be updated.

[David Roche, 2014-04-22 15:27:27]

https://codereview.chromium.org/204983009/diff/40001/components/policy/resour...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/204983009/diff/40001/components/policy/resour...
components/policy/resources/policy_templates.json:3663: 'supported_on':
['chrome_os:32-34'],
On 2014/04/22 15:18:53, Joao da Silva wrote:
> 35 has already branched and includes this policy. Was the support removed on
> that branch? If not then this needs to be updated.

Done.

[David Roche, 2014-04-22 15:28:43]

The CQ bit was checked by davidroche@chromium.org

[commit-bot: I haz the power, 2014-04-22 15:29:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davidroche@chromium.org/204983009/60001

[commit-bot: I haz the power, 2014-04-22 16:37:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-22 16:37:07]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[David Roche, 2014-04-29 17:51:11]

The CQ bit was checked by davidroche@chromium.org

[commit-bot: I haz the power, 2014-04-29 17:53:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davidroche@chromium.org/204983009/60001

[commit-bot: I haz the power, 2014-04-29 19:47:50]

Change committed as 266939