Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: runtime/vm/object.cc

Issue 204983008: Rework how ServiceObjects are created and cached in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js / fix 1 bug Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/service/service.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 3830 matching lines...) Expand 10 before | Expand all | Expand 10 after
3841 3841
3842 const Error& err = Error::Handle(EnsureIsFinalized(Isolate::Current())); 3842 const Error& err = Error::Handle(EnsureIsFinalized(Isolate::Current()));
3843 if (!err.IsNull()) { 3843 if (!err.IsNull()) {
3844 jsobj.AddProperty("error", err); 3844 jsobj.AddProperty("error", err);
3845 } 3845 }
3846 jsobj.AddProperty("implemented", is_implemented()); 3846 jsobj.AddProperty("implemented", is_implemented());
3847 jsobj.AddProperty("abstract", is_abstract()); 3847 jsobj.AddProperty("abstract", is_abstract());
3848 jsobj.AddProperty("patch", is_patch()); 3848 jsobj.AddProperty("patch", is_patch());
3849 jsobj.AddProperty("finalized", is_finalized()); 3849 jsobj.AddProperty("finalized", is_finalized());
3850 jsobj.AddProperty("const", is_const()); 3850 jsobj.AddProperty("const", is_const());
3851 jsobj.AddProperty("super", Class::Handle(SuperClass())); 3851 const Class& superClass = Class::Handle(SuperClass());
3852 if (!superClass.IsNull()) {
3853 jsobj.AddProperty("super", superClass);
3854 }
3852 jsobj.AddProperty("library", Object::Handle(library())); 3855 jsobj.AddProperty("library", Object::Handle(library()));
3853 const Script& script = Script::Handle(this->script()); 3856 const Script& script = Script::Handle(this->script());
3854 if (!script.IsNull()) { 3857 if (!script.IsNull()) {
3855 intptr_t line_number = 0; 3858 intptr_t line_number = 0;
3856 intptr_t column_number = 0; 3859 intptr_t column_number = 0;
3857 script.GetTokenLocation(token_pos(), &line_number, &column_number); 3860 script.GetTokenLocation(token_pos(), &line_number, &column_number);
3858 jsobj.AddProperty("script", script); 3861 jsobj.AddProperty("script", script);
3859 jsobj.AddProperty("line", line_number); 3862 jsobj.AddProperty("line", line_number);
3860 jsobj.AddProperty("col", column_number); 3863 jsobj.AddProperty("col", column_number);
3861 } 3864 }
(...skipping 14131 matching lines...) Expand 10 before | Expand all | Expand 10 after
17993 return "_MirrorReference"; 17996 return "_MirrorReference";
17994 } 17997 }
17995 17998
17996 17999
17997 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const { 18000 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const {
17998 Instance::PrintToJSONStream(stream, ref); 18001 Instance::PrintToJSONStream(stream, ref);
17999 } 18002 }
18000 18003
18001 18004
18002 } // namespace dart 18005 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/service/service.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698