Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: runtime/vm/object.cc

Issue 204983008: Rework how ServiceObjects are created and cached in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: edits Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 3841 matching lines...) Expand 10 before | Expand all | Expand 10 after
3852 3852
3853 const Error& err = Error::Handle(EnsureIsFinalized(Isolate::Current())); 3853 const Error& err = Error::Handle(EnsureIsFinalized(Isolate::Current()));
3854 if (!err.IsNull()) { 3854 if (!err.IsNull()) {
3855 jsobj.AddProperty("error", err); 3855 jsobj.AddProperty("error", err);
3856 } 3856 }
3857 jsobj.AddProperty("implemented", is_implemented()); 3857 jsobj.AddProperty("implemented", is_implemented());
3858 jsobj.AddProperty("abstract", is_abstract()); 3858 jsobj.AddProperty("abstract", is_abstract());
3859 jsobj.AddProperty("patch", is_patch()); 3859 jsobj.AddProperty("patch", is_patch());
3860 jsobj.AddProperty("finalized", is_finalized()); 3860 jsobj.AddProperty("finalized", is_finalized());
3861 jsobj.AddProperty("const", is_const()); 3861 jsobj.AddProperty("const", is_const());
3862 jsobj.AddProperty("super", Class::Handle(SuperClass())); 3862 const Class& superClass = Class::Handle(SuperClass());
3863 if (!superClass.IsNull()) {
3864 jsobj.AddProperty("super", superClass);
3865 }
3863 jsobj.AddProperty("library", Object::Handle(library())); 3866 jsobj.AddProperty("library", Object::Handle(library()));
3864 const Script& script = Script::Handle(this->script()); 3867 const Script& script = Script::Handle(this->script());
3865 if (!script.IsNull()) { 3868 if (!script.IsNull()) {
3866 intptr_t line_number = 0; 3869 intptr_t line_number = 0;
3867 intptr_t column_number = 0; 3870 intptr_t column_number = 0;
3868 script.GetTokenLocation(token_pos(), &line_number, &column_number); 3871 script.GetTokenLocation(token_pos(), &line_number, &column_number);
3869 jsobj.AddProperty("script", script); 3872 jsobj.AddProperty("script", script);
3870 jsobj.AddProperty("line", line_number); 3873 jsobj.AddProperty("line", line_number);
3871 jsobj.AddProperty("col", column_number); 3874 jsobj.AddProperty("col", column_number);
3872 } 3875 }
(...skipping 14082 matching lines...) Expand 10 before | Expand all | Expand 10 after
17955 return "_MirrorReference"; 17958 return "_MirrorReference";
17956 } 17959 }
17957 17960
17958 17961
17959 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const { 17962 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const {
17960 Instance::PrintToJSONStream(stream, ref); 17963 Instance::PrintToJSONStream(stream, ref);
17961 } 17964 }
17962 17965
17963 17966
17964 } // namespace dart 17967 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698