Source/web/WebSharedWorkerImpl.cpp - Issue 204983007: Make ThreadableLoader class to use references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebSharedWorkerImpl.cpp

Issue 204983007: Make ThreadableLoader class to use references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changes per review commets Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebSharedWorkerImpl.cpp

diff --git a/Source/web/WebSharedWorkerImpl.cpp b/Source/web/WebSharedWorkerImpl.cpp

index 7898c73a23bdfc255a16052b109c4bff5eda4d6f..ede5e8b3f39daf0abbb221939db36048274eb9c9 100644

--- a/Source/web/WebSharedWorkerImpl.cpp

+++ b/Source/web/WebSharedWorkerImpl.cpp

@@ -89,11 +89,12 @@ public:

void load(ExecutionContext* loadingContext, const KURL& scriptURL, const Closure& receiveResponseCallback, const Closure& finishCallback)

{

+ ASSERT(loadingContext);

m_receiveResponseCallback = receiveResponseCallback;

m_finishCallback = finishCallback;

m_scriptLoader->setTargetType(ResourceRequest::TargetIsSharedWorker);

m_scriptLoader->loadAsynchronously(

- loadingContext, scriptURL, DenyCrossOriginRequests, this);

+ *loadingContext, scriptURL, DenyCrossOriginRequests, this);

}

void didReceiveResponse(unsigned long identifier, const ResourceResponse& response) OVERRIDE