Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Unified Diff: Source/web/AssociatedURLLoader.cpp

Issue 204983007: Make ThreadableLoader class to use references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/AssociatedURLLoader.cpp
diff --git a/Source/web/AssociatedURLLoader.cpp b/Source/web/AssociatedURLLoader.cpp
index 44d1a61ef5dbe6cb4a837fa24d513ddf5660aaaa..aa6e7ac1be688ac56c77ebd128583faa9768c263 100644
--- a/Source/web/AssociatedURLLoader.cpp
+++ b/Source/web/AssociatedURLLoader.cpp
@@ -347,8 +347,10 @@ void AssociatedURLLoader::loadAsynchronously(const WebURLRequest& request, WebUR
options.dataBufferingPolicy = DoNotBufferData;
const ResourceRequest& webcoreRequest = newRequest.toResourceRequest();
+ // FIXME: We can not create DocumentThreadableLoader if document does not exist for the frame.
Inactive 2014/03/22 15:13:06 Why the FIXME? The assertion should suffice. The c
maheshkk 2014/03/24 18:17:48 Done.
Document* webcoreDocument = m_frameImpl->frame()->document();
- m_loader = DocumentThreadableLoader::create(webcoreDocument, m_clientAdapter.get(), webcoreRequest, options);
+ ASSERT(webcoreDocument);
+ m_loader = DocumentThreadableLoader::create(*webcoreDocument, m_clientAdapter.get(), webcoreRequest, options);
} else {
// FIXME: return meaningful error codes.
m_clientAdapter->setDelayedError(ResourceError());
« Source/core/loader/WorkerThreadableLoader.cpp ('K') | « Source/core/workers/WorkerScriptLoader.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698