Source/web/AssociatedURLLoader.cpp - Issue 204983007: Make ThreadableLoader class to use references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/AssociatedURLLoader.cpp

Issue 204983007: Make ThreadableLoader class to use references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/AssociatedURLLoader.cpp

diff --git a/Source/web/AssociatedURLLoader.cpp b/Source/web/AssociatedURLLoader.cpp

index 2d57aaa3e2ed5f6b7a6c278e7db40630b5cf7282..df1fcfe49c69cb88baca78925f0a208a1531c157 100644

--- a/Source/web/AssociatedURLLoader.cpp

+++ b/Source/web/AssociatedURLLoader.cpp

@@ -351,7 +351,8 @@ void AssociatedURLLoader::loadAsynchronously(const WebURLRequest& request, WebUR

const ResourceRequest& webcoreRequest = newRequest.toResourceRequest();

Document* webcoreDocument = m_frameImpl->frame()->document();

- m_loader = DocumentThreadableLoader::create(webcoreDocument, m_clientAdapter.get(), webcoreRequest, options);

+ ASSERT(webcoreDocument);

+ m_loader = DocumentThreadableLoader::create(*webcoreDocument, m_clientAdapter.get(), webcoreRequest, options);

} else {

// FIXME: return meaningful error codes.

m_clientAdapter->setDelayedError(ResourceError());

« no previous file with comments | « Source/core/xml/XMLHttpRequest.cpp ('k') | Source/web/WebEmbeddedWorkerImpl.cpp » ('j') | no next file with comments »