Source/core/loader/ThreadableLoader.h - Issue 204983007: Make ThreadableLoader class to use references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/ThreadableLoader.h

Issue 204983007: Make ThreadableLoader class to use references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/ThreadableLoader.h

diff --git a/Source/core/loader/ThreadableLoader.h b/Source/core/loader/ThreadableLoader.h

index a1092d24400ebd012fedde269dfe04abdf26b829..4f88e1e31326979d84414391eb4c7a0627aa9837 100644

--- a/Source/core/loader/ThreadableLoader.h

+++ b/Source/core/loader/ThreadableLoader.h

@@ -80,8 +80,8 @@ namespace WebCore {

class ThreadableLoader {

WTF_MAKE_NONCOPYABLE(ThreadableLoader);

public:

- static void loadResourceSynchronously(ExecutionContext*, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&);

- static PassRefPtr<ThreadableLoader> create(ExecutionContext*, ThreadableLoaderClient*, const ResourceRequest&, const ThreadableLoaderOptions&);

+ static void loadResourceSynchronously(ExecutionContext&, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&);

+ static PassRefPtr<ThreadableLoader> create(ExecutionContext&, ThreadableLoaderClient*, const ResourceRequest&, const ThreadableLoaderOptions&);

virtual void cancel() = 0;

void ref() { refThreadableLoader(); }