Source/core/inspector/InspectorResourceAgent.cpp - Issue 204983007: Make ThreadableLoader class to use references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorResourceAgent.cpp

Issue 204983007: Make ThreadableLoader class to use references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/InspectorResourceAgent.cpp

diff --git a/Source/core/inspector/InspectorResourceAgent.cpp b/Source/core/inspector/InspectorResourceAgent.cpp

index 29accb85010442651df65dff82a0fe634ed6914b..fb128590774750db6929c5bfd80ab0c7462947d6 100644

--- a/Source/core/inspector/InspectorResourceAgent.cpp

+++ b/Source/core/inspector/InspectorResourceAgent.cpp

@@ -752,7 +752,7 @@ void InspectorResourceAgent::loadResourceForFrontend(ErrorString* errorString, c

options.crossOriginRequestPolicy = AllowCrossOriginRequests;

InspectorThreadableLoaderClient* inspectorThreadableLoaderClient = new InspectorThreadableLoaderClient(callback);

- RefPtr<DocumentThreadableLoader> loader = DocumentThreadableLoader::create(document, inspectorThreadableLoaderClient, request, options);

+ RefPtr<DocumentThreadableLoader> loader = DocumentThreadableLoader::create(*document, inspectorThreadableLoaderClient, request, options);

if (!loader) {

inspectorThreadableLoaderClient->didFailLoaderCreation();

return;