Make ThreadableLoader class to use references

Source/core/workers/WorkerScriptLoader.cpp

 /*
  * Copyright (C) 2009 Apple Inc. All Rights Reserved.
  * Copyright (C) 2009, 2011 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 37 matching lines @@
     , m_targetType(ResourceRequest::TargetIsWorker)
 {
 }
 
 WorkerScriptLoader::~WorkerScriptLoader()
 {
 }
 
 void WorkerScriptLoader::loadSynchronously(ExecutionContext* executionContext, const KURL& url, CrossOriginRequestPolicy crossOriginRequestPolicy)
 {
     m_url = url;

[Inactive, 2014/03/31 17:43:26]

We should probably add an ASSERT(executionContext) here.

[maheshkk, 2014/03/31 20:46:49]

I have moved this method and all the callers to use reference. 

 
     OwnPtr<ResourceRequest> request(createResourceRequest());
     if (!request)
         return;
 
     ASSERT_WITH_SECURITY_IMPLICATION(executionContext->isWorkerGlobalScope());
 
     ThreadableLoaderOptions options;
     options.allowCredentials = AllowStoredCredentials;
     options.crossOriginRequestPolicy = crossOriginRequestPolicy;
     // FIXME: Should we add EnforceScriptSrcDirective here?
     options.contentSecurityPolicyEnforcement = DoNotEnforceContentSecurityPolicy;
 
-    WorkerThreadableLoader::loadResourceSynchronously(toWorkerGlobalScope(executionContext), *request, *this, options);
+    WorkerThreadableLoader::loadResourceSynchronously(toWorkerGlobalScope(*executionContext), *request, *this, options);
 }
 
 void WorkerScriptLoader::loadAsynchronously(ExecutionContext* executionContext, const KURL& url, CrossOriginRequestPolicy crossOriginRequestPolicy, WorkerScriptLoaderClient* client)
 {
     ASSERT(client);

[Inactive, 2014/03/31 17:43:26]

We should probably add an ASSERT(executionContext) here.

[maheshkk, 2014/03/31 20:46:49]

I have moved this method and all the callers to use reference. 

     m_client = client;
     m_url = url;
 
     OwnPtr<ResourceRequest> request(createResourceRequest());
     if (!request)
         return;
 
     ThreadableLoaderOptions options;
     options.allowCredentials = AllowStoredCredentials;
     options.crossOriginRequestPolicy = crossOriginRequestPolicy;
 
     // During create, callbacks may happen which remove the last reference to this object.
     RefPtr<WorkerScriptLoader> protect(this);
-    m_threadableLoader = ThreadableLoader::create(executionContext, this, *request, options);
+    m_threadableLoader = ThreadableLoader::create(*executionContext, this, *request, options);
 }
 
 const KURL& WorkerScriptLoader::responseURL() const
 {
     ASSERT(!failed());
     return m_responseURL;
 }
 
 PassOwnPtr<ResourceRequest> WorkerScriptLoader::createResourceRequest()
 {
@@ skipping 80 matching lines @@
 void WorkerScriptLoader::notifyFinished()
 {
     if (!m_client || m_finishing)
         return;
 
     m_finishing = true;
     m_client->notifyFinished();
 }
 
 } // namespace WebCore