Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 204983003: Only use analytic effect-based clipping when AA is required by at least one element. (Closed)

Created:
6 years, 9 months ago by bsalomon
Modified:
6 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Only use analytic effect-based clipping when AA is required by at least one element. BUG=352718 Committed: http://code.google.com/p/skia/source/detail?r=13867

Patch Set 1 #

Patch Set 2 : Add test to ignored-tests.txt #

Patch Set 3 : whitespace #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
bsalomon
6 years, 9 months ago (2014-03-19 20:06:49 UTC) #1
robertphillips
lgtm
6 years, 9 months ago (2014-03-19 20:09:02 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-19 20:11:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/204983003/1
6 years, 9 months ago (2014-03-19 20:11:08 UTC) #4
bsalomon
The CQ bit was unchecked by bsalomon@google.com
6 years, 9 months ago (2014-03-19 20:21:34 UTC) #5
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-19 20:28:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/204983003/40001
6 years, 9 months ago (2014-03-19 20:28:20 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 20:28:25 UTC) #8
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-19 20:28:25 UTC) #9
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-19 20:54:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/204983003/60001
6 years, 9 months ago (2014-03-19 20:54:34 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 21:26:39 UTC) #12
Message was sent while issue was closed. 
Change committed as 13867

Powered by Google App Engine
This is Rietveld 408576698