Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2049773004: [Reland] Mojo: Eliminate duplicate C API symbols (Closed)

Created:
4 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 6 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] Mojo: Eliminate duplicate C API symbols This gets rid of the duplicate definitions of public Mojo C API symbols, instead making mojo/public/c/system the singular source of these definitions. This allows targets to be linked against mojo/public libraries without requiring any additional EDK dependencies at build time. To facilitate this the EDK uses the same set of API thunks as the public library, and the public library exposes a special embedder API (distinct from the DSO MojoSetSystemThunks call used by the native app loader) for setting these thunks. The MojoSetSystemThunks API is moved to a module which is only linked directly into app DSOs. Because mojo/public/c/system and mojo/edk/system are now both components, and because there are no longer redundant exports between the two, it's now safe for targets to depend on either one or both of them as needed without encountering duplicate definitions. Also some opportunistic cleanup of Mojo build rules. Reland of https://codereview.chromium.org/2044023004 Previous failures were caused by the mojo/public/c/system component using "system" as its name, breaking -lsystem behavior in some linking scenarios. This reland changes the output_name of that target. BUG=612500 TBR=jam@chromium.org Committed: https://crrev.com/b04b89b524f89a744e2a0e34a1cfedc84d9085c5 Cr-Commit-Position: refs/heads/master@{#398776}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -883 lines) Patch
M mojo/edk/embedder/BUILD.gn View 4 chunks +2 lines, -10 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 2 chunks +5 lines, -0 lines 0 comments Download
A mojo/edk/embedder/entrypoints.h View 1 chunk +22 lines, -0 lines 0 comments Download
M mojo/edk/embedder/entrypoints.cc View 5 chunks +145 lines, -96 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 2 chunks +1 line, -13 lines 0 comments Download
M mojo/mojo.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/mojo_base.gyp View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/mojo_edk.gyp View 3 chunks +4 lines, -10 lines 0 comments Download
M mojo/mojo_edk_nacl.gyp View 3 chunks +4 lines, -8 lines 0 comments Download
M mojo/mojo_edk_tests.gyp View 5 chunks +11 lines, -4 lines 0 comments Download
M mojo/mojo_public.gyp View 1 5 chunks +11 lines, -41 lines 0 comments Download
D mojo/mojo_variables.gypi View 1 chunk +0 lines, -50 lines 0 comments Download
M mojo/public/c/system/BUILD.gn View 1 2 chunks +21 lines, -30 lines 0 comments Download
A mojo/public/c/system/set_thunks_for_app.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M mojo/public/c/system/system_export.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/c/system/thunks.h View 2 chunks +10 lines, -49 lines 0 comments Download
A + mojo/public/c/system/thunks.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M mojo/public/mojo_application.gni View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/platform/native/BUILD.gn View 1 chunk +0 lines, -29 lines 0 comments Download
D mojo/public/platform/native/system_thunks.h View 1 chunk +0 lines, -213 lines 0 comments Download
D mojo/public/platform/native/system_thunks.cc View 1 chunk +0 lines, -287 lines 0 comments Download
D mojo/public/platform/native/thunk_export.h View 1 chunk +0 lines, -18 lines 0 comments Download
M services/shell/runner/host/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/shell/runner/host/native_application_support.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +1 line, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049773004/20001
4 years, 6 months ago (2016-06-09 01:20:27 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 03:59:08 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 04:01:02 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b04b89b524f89a744e2a0e34a1cfedc84d9085c5
Cr-Commit-Position: refs/heads/master@{#398776}

Powered by Google App Engine
This is Rietveld 408576698