Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader.h

Issue 2049743004: Integrates the SnapshotController into the PrerenderingLoader to provide logic for determining when… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@turnon
Patch Set: Replaces Stop() calls with unique_ptr.reset for better instance handling Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/prerendering_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/prerendering_loader.h
diff --git a/chrome/browser/android/offline_pages/prerendering_loader.h b/chrome/browser/android/offline_pages/prerendering_loader.h
index 22659e96a3609d311ef21505beda494329244112..1af54f525d328976e527fd3603b277f9f645f66d 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader.h
+++ b/chrome/browser/android/offline_pages/prerendering_loader.h
@@ -10,6 +10,7 @@
#include "base/callback.h"
#include "chrome/browser/android/offline_pages/prerender_adapter.h"
#include "components/offline_pages/background/offliner.h"
+#include "components/offline_pages/snapshot_controller.h"
class GURL;
@@ -29,7 +30,8 @@ namespace offline_pages {
// the page loading in the background. It operates on a single thread and
// needs to run on BrowserThread::UI to work with the PrerenderManager.
// It supports a single load request at a time.
-class PrerenderingLoader : public PrerenderAdapter::Observer {
+class PrerenderingLoader : public PrerenderAdapter::Observer,
+ public SnapshotController::Client {
public:
// Reports status of a load page request with loaded contents if available.
typedef base::Callback<void(Offliner::RequestStatus, content::WebContents*)>
@@ -79,6 +81,9 @@ class PrerenderingLoader : public PrerenderAdapter::Observer {
void OnPrerenderDomContentLoaded() override;
void OnPrerenderStop() override;
+ // SnapshotController::Client implementation:
+ void StartSnapshot() override;
+
private:
// State of the loader (only one request may be active at a time).
enum class State {
@@ -104,6 +109,9 @@ class PrerenderingLoader : public PrerenderAdapter::Observer {
// Tracks loading state including whether the Loader is idle.
State state_;
+ // Handles determining when to report page is LOADED.
+ std::unique_ptr<SnapshotController> snapshot_controller_;
+
// Not owned.
content::BrowserContext* browser_context_;
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/prerendering_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698