Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader_unittest.cc

Issue 2049743004: Integrates the SnapshotController into the PrerenderingLoader to provide logic for determining when… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@turnon
Patch Set: Added comment wrt petewil@ feedback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc b/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
index 8e7643aa390b6fbbb716bd5b1597f7367dc82973..d7f28d9f43fad5fff6b6f6b5370fd9f0b6cf2b01 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
+++ b/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
@@ -182,6 +182,8 @@ TEST_F(PrerenderingLoaderTest, LoadPageLoadSucceededFromDomContentLoaded) {
base::Bind(&PrerenderingLoaderTest::OnLoadDone, base::Unretained(this))));
test_adapter()->GetObserver()->OnPrerenderDomContentLoaded();
+ // Skip SnapshotController's wait time and emulate StartSnapshot call.
+ loader()->StartSnapshot();
PumpLoop();
EXPECT_FALSE(loader()->IsIdle());
EXPECT_TRUE(loader()->IsLoaded());

Powered by Google App Engine
This is Rietveld 408576698