Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2049723004: Revert of Limit foreign fetch to only intercept requests made from secure contexts. (Closed)

Created:
4 years, 6 months ago by Marijn Kruisselbrink
Modified:
4 years, 6 months ago
Reviewers:
kinuko, dcheng
CC:
blink-reviews, blink-worker-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, falken, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, kinuko+watch, loading-reviews_chromium.org, michaeln, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nhiroki, serviceworker-reviews, tzik, ncarter (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Limit foreign fetch to only intercept requests made from secure contexts. (patchset #2 id:40001 of https://codereview.chromium.org/2032653003/ ) Reason for revert: ResourceRequest::initiated_in_secure_context should have a default value, now it's causing failures on some MSAN bots Original issue's description: > Limit foreign fetch to only intercept requests made from secure contexts. > > Implements step 5 of "Handle Foreign Fetch" in [1] > > [1]: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#on-foreign-fetch-request-algorithm > > BUG=540509 > > Committed: https://crrev.com/dd933bda0baa6a13ab0120f0056a2b783e459efb > Cr-Commit-Position: refs/heads/master@{#398752} TBR=dcheng@chromium.org,kinuko@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=540509 Committed: https://crrev.com/3dc66db842e4bd72626711835d2e61b3aedc468f Cr-Commit-Position: refs/heads/master@{#398772}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
Marijn Kruisselbrink
Created Revert of Limit foreign fetch to only intercept requests made from secure contexts.
4 years, 6 months ago (2016-06-09 03:41:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049723004/1
4 years, 6 months ago (2016-06-09 03:41:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 03:42:56 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 03:44:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dc66db842e4bd72626711835d2e61b3aedc468f
Cr-Commit-Position: refs/heads/master@{#398772}

Powered by Google App Engine
This is Rietveld 408576698