Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2049703002: Document dm error about missing skps (Closed)

Created:
4 years, 6 months ago by mkollaro
Modified:
4 years, 6 months ago
Reviewers:
bsalomon, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Document dm error about missing skps BUG=None GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2049703002 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2049703002 Committed: https://skia.googlesource.com/skia/+/2f64bf7931368c4ad8c18c8516fe92d14795916d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M site/dev/testing/testing.md View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mkollaro
I'm wondering if it might make more sense to test skps optionally (e.g. the --skps ...
4 years, 6 months ago (2016-06-08 14:00:36 UTC) #2
mkollaro
4 years, 6 months ago (2016-06-08 14:01:36 UTC) #4
mtklein
lgtm
4 years, 6 months ago (2016-06-08 16:24:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049703002/1
4 years, 6 months ago (2016-06-08 16:24:30 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 16:25:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2f64bf7931368c4ad8c18c8516fe92d14795916d

Powered by Google App Engine
This is Rietveld 408576698