Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2049683004:
[gn] Skip gyp_v8 when gn should run (Closed)
|
Created:
4 years, 6 months ago by Michael Achenbach Modified:
4 years, 6 months ago CC:
Michael Achenbach, v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[gn] Skip gyp_v8 when gn should run
This ports logic from gyp_chromium to skip gyp by environment
variable. The variable name stays the same for chromium
and v8 as it is shared across other infra tools.
BUG=chromium:474921
NOTRY=true
Committed: https://crrev.com/cb18c379a835850bf8f82b6020b9de96bfe063ef
Cr-Commit-Position: refs/heads/master@{#36860}
Patch Set 1 #Patch Set 2 : Fix #Messages
Total messages: 22 (13 generated)
Description was changed from ========== [gn] Skip gyp_v8 when gn should run BUG= ========== to ========== [gn] Skip gyp_v8 when gn should run This ports logic from gyp_chromium to skip gyp by environment variable. The variable name stays the same for chromium and v8 as it is shared across other infra tools. BUG=chromium:474921 ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org, vogelheim@chromium.org
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049683004/1
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049683004/20001
PTAL
lgtm
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049683004/20001
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049683004/20001
Description was changed from ========== [gn] Skip gyp_v8 when gn should run This ports logic from gyp_chromium to skip gyp by environment variable. The variable name stays the same for chromium and v8 as it is shared across other infra tools. BUG=chromium:474921 ========== to ========== [gn] Skip gyp_v8 when gn should run This ports logic from gyp_chromium to skip gyp by environment variable. The variable name stays the same for chromium and v8 as it is shared across other infra tools. BUG=chromium:474921 NOTRY=true ==========
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049683004/20001
Message was sent while issue was closed.
Description was changed from ========== [gn] Skip gyp_v8 when gn should run This ports logic from gyp_chromium to skip gyp by environment variable. The variable name stays the same for chromium and v8 as it is shared across other infra tools. BUG=chromium:474921 NOTRY=true ========== to ========== [gn] Skip gyp_v8 when gn should run This ports logic from gyp_chromium to skip gyp by environment variable. The variable name stays the same for chromium and v8 as it is shared across other infra tools. BUG=chromium:474921 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [gn] Skip gyp_v8 when gn should run This ports logic from gyp_chromium to skip gyp by environment variable. The variable name stays the same for chromium and v8 as it is shared across other infra tools. BUG=chromium:474921 NOTRY=true ========== to ========== [gn] Skip gyp_v8 when gn should run This ports logic from gyp_chromium to skip gyp by environment variable. The variable name stays the same for chromium and v8 as it is shared across other infra tools. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/cb18c379a835850bf8f82b6020b9de96bfe063ef Cr-Commit-Position: refs/heads/master@{#36860} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/cb18c379a835850bf8f82b6020b9de96bfe063ef Cr-Commit-Position: refs/heads/master@{#36860} |
