Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 2049643002: Version 5.2.361.18 (cherry-pick) (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.2
Target Ref:
refs/pending/branch-heads/5.2
Project:
v8
Visibility:
Public.

Description

Version 5.2.361.18 (cherry-pick) Merged 35e0f01fb9e9d191663e2993031829db38e706b5 Merged 4d9149e1befb9fa56bc498bd2467134173be85b3 X87: Revert of [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. (patchset #1 id:1 of https://codereview.chromium.org/1968453002/ ). X87: [x64/ia32] Deal with the non-transitivity of InstructionSelector::CanCover() when folding loads into branches. BUG=chromium:611976 R=hablich@chromium.org LOG=N NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -63 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 5 chunks +27 lines, -62 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
zhengxing.li
4 years, 6 months ago (2016-06-08 06:32:58 UTC) #1
Michael Hablich
On 2016/06/08 06:32:58, zhengxing.li wrote: lgtm
4 years, 6 months ago (2016-06-08 08:25:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049643002/1
4 years, 6 months ago (2016-06-08 08:48:58 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 08:49:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698